search

mfbonfigli / gocesiumtiler

A Cesium.js point cloud 3D tiles generator from LAS files written in Golang
Mozilla Public License 2.0
195 stars 40 forks source link

Flag -f/-folder produces "octree already built" error #20

Closed majos95 closed 3 years ago

majos95 commented 3 years ago

After trying it with different Point Clouds, flag -f does not seem to work. After correctly processing the first file, an "octree already built" error appears.

mfbonfigli commented 3 years ago

Oh totally right. I think the issue is here https://github.com/mfbonfigli/gocesiumtiler/blob/71716873b114f1b1f420af17d89de9446761e0ba/pkg/tiler.go#L43 line 43 should be inside the for loop. If you want to check it out and submit a CR happy to review it :)

majos95 commented 3 years ago

That did not fix it, but it led me to the solution, the problem is on the Build() itself. I'll submit a CR as soon as possible.

mfbonfigli commented 3 years ago

Interesting, I would have expected that small change to fix it. Feel free to send a CR out, in the meanwhile I'll try to do some experiments on my side.

ghost commented 3 years ago

Hello, any updates on this issue?

mfbonfigli commented 3 years ago

I just released a new version 1.2.1 that should hopefully fix this. Please give it a try. Closing the issue for now, feel free to reopen it or create a new one if the issue persists.