mgastner / cartogram-cpp

Cartogram generator in C++
MIT License
8 stars 4 forks source link

Should we catch errors in main or in implementation files? #124

Closed adisidev closed 1 month ago

adisidev commented 2 years ago

For instance, shall we include the file reading error in read_csv instead of main?

adisidev commented 2 years ago

Additionally, what is the purpose of including a try-catch block over check_topology?

adisidev commented 1 month ago

We should catch them in implementation files as to not clutter main. Either #167 or another future pull request should deal with this soon.

adisidev commented 1 month ago

Similar to #172