search

mgastner / cartogram-cpp

Cartogram generator in C++
MIT License
8 stars 4 forks source link

Remove redundancy in naming #144

Open adisidev opened 2 years ago

adisidev commented 2 years ago

It does not make sense to call the member function inside the cart_info object cart_total_target_area, as it is implicit that the target area would be of the entire cartogram as it is called from a cart_info object.

Similarly, change total_inset_area to area.

adisidev commented 2 years ago

https://github.com/mgastner/cartogram-cpp/pull/136#discussion_r918568195

On a small side note, should we also replace total_inset_area() with just area? The fact that it is the area of the inset is implicit in having it called from an object of the class inset or inside a member function. We could make similar changes in other places such as set_inset_name --> set_name, and total_target_area --> target_area.