mgastner / cartogram-cpp

Cartogram generator in C++
MIT License
8 stars 4 forks source link

Pr/139 #146

Closed mgastner closed 2 years ago

mgastner commented 2 years ago

This branch starts from a copy of edliau:main.

I fixed topology problems caused by the cut at the antimeridian. I also corrected numerous errors in the population CSV. I commented out the line

new_json["features"][i]["id"] = old_json["features"][index]["id"];

in write_geojson.cpp which caused a bug for me and seems to be generally useless. Now the command

cartogram sample_data/russia_by_federal_subject_since_2008/russia_by_federal_subject_since_2008.geojson sample_data/russia_by_federal_subject_since_2008/russia_population_2010.csv -pQs

works fine on Ubuntu 22.04.

mgastner commented 2 years ago

I made the requested changes. Please check whether everything is in working order. Singapore does not pass the stress test, but this issue is related to near-zero target areas, which should be the topic of a separate pull request.