Open adisidev opened 1 month ago
CMakeLists.txt Looks like the previous attachment didn't make it.
I now believe the progress bar should account for area_expansion_factor
(previously area_drift
), as our map often shows done, but integrations keep going on, as area_expansion_factor
is above the threshold.
area_expansion_factor
is now already accounted for, given that it is taken target areas and current areas are normalised, meaning that the area error would be affected by the area_expansion_factor
. Which begs the question, do we need the area_expansion_factor
condition at all now?
Now, the problem is different. When the progress jumps from 0.03 to say 0.018, since we assume each integration will make area error 1/5, I believe the progress bar jumps to 100%.
The progress bar, however, still goes back and forth (especially for US counties). If we solve us_counties
's bug and that fixes the progress bar bug, have a look at 5b78bf6a495e18f1f829790fd65971b55932493c to recreate the issue.
https://github.com/mgastner/cartogram-cpp/commit/f93c35026e300677432bf346cc0f4c49d3fa75d0
In case our maps now converge, making this issue temporarily irrelevant, please have a look at commit
f93c350
. If theCMakeLists.txt
file does not work for you, try the attached one instead.