mholow / gsp-r10-adapter

MIT License
60 stars 13 forks source link

measured vs estimated spin in GSPro #23

Open etogburn opened 1 year ago

etogburn commented 1 year ago

I love that the connector shows ball type and spin measured/estimated in the table format now. to make it easier to see, is there a way to send that information (as a 1 or 0 or something like that) to GSPro to be put in one of the data tiles that are not used by the R10? I'd love to be able to tell quickly in GSPro if the spin was measured similar to the italics in the garmin app.

alleexx commented 7 months ago

I had the same request and implemented it as closure rate in my version of the connector:

https://github.com/alleexx/gsp-r10-adapter-fixpath/releases/tag/1.4

mholow commented 7 months ago

@alleexx very cool. Open to pull requests if you’d like to get the changes back into this repo.

alleexx commented 7 months ago

@mholow I will. Was not sure you are still working on the connector. I also made another addition for some sanity check on the club path value provided by R10 and disregard it if too high as these were misreads. Will also post that one - fits actually to the other request for VLA = 0 checks which I also occasionally get. These did not come up too often for me to make a fix on the data but I might.

rbrundritt commented 7 months ago

Based on the source code, it looks like there could be 4 possible ways the spin is calculated; ratio (guessing this is a ratio of side to back spin), ball flight (guessing this is measured over the full ball flight), measured (guessing this is a measured value over a short distance), and "other" which may be for future use.

alleexx commented 7 months ago

So far I have only checked for measured and non measured. In my indoor setup I have only seen measured and non measured being "ratio" = calculated in my interpretation. Never have seen the other 2 I think.

rbrundritt commented 7 months ago

Good to know. I my app I'll simplify to calculated/measured, and have "ball flight" fall back to measured, and "other" fallback to calculated.