search

michael-milette / moodle-filter_filtercodes

FilterCodes filter for Moodle enables content creators to easily customize and personalize course and site content using plain text tags (no HTML). For premium support, contact us at https://www.tngconsulting.ca/contact
https://moodle.org/plugins/filter_filtercodes
GNU General Public License v3.0
32 stars 44 forks source link

{now} filtercode not working with format #168

Closed hengeb closed 2 years ago

hengeb commented 2 years ago

With my Moodle installation (Moodle 3.11.3, plugin version 2.2.4 (2021052505), PHP 7.4.22, timezone Europe/Berlin; unfortunately I have to possibility to change any of these for testing purposes) the {now} filter code only shows a correct result when there is no format argument included. In any other case the filter code will break the page.

example:

raw page content: "ABC {now} DEF {now} GHI {now strftimetime} JKL {now strftimedate} MNO {now strftimedatetime} PQR {now} STU"

is expected to be rendered as: "ABC 22.09.21 DEF 22.09.21 GHI 10:29 JKL 22 September 2021 MNO 22 September 2021, 10:29 AM PQR 22.09.21 STU"

What I get instead is: "ABC 22.09.21 DEF 22.09.21 GHI 10:29 STU"

Not only are some of the codes not showing, they also remove some of the contents that follow outside the code.

regards Henrik

michael-milette commented 2 years ago

This is related to #166 .

michael-milette commented 2 years ago

Hi @hengeb ,

I think I have the issues with the date/time-related tags fixed. This includes the following tags:

This fix addresses the issues described in #166 , #168 and #191 including cutting off of text and multiple instances of these tags not appearing or not being processed correctly.

The fix has been pushed to the code here on GitHub for now. If you have a chance, I would appreciate it very much if you would try it out and let me know if it works properly for you. If it does, I will include the fix in the upcoming release of FilterCodes on Moodle.org.

Tip: Type {now} manually in Moodle. Do not copy and paste your example from GitHub. Doing so often introduces extra HTML codes and/or characters which will prevent the tag from working.

Best regards,

Michael

michael-milette commented 2 years ago

I am closing this issue with the assumption that it is all working now as there has been no feedback over the past month. If there is a problem, please open a new issue and mention issue #168.

Best regards,

Michael