Bug: FilterCodes FontAwesome conflict with Activity name auto linking (core)

joostelshoff commented 1 year ago

Prerequisites

[X] I'm reporting the issue to the correct repository.
[X] I am running the latest version of this plugin (if not, please upgrade first).
[X] I checked the README.md and Wiki documentation but did not find my answer.
[X] I searched to make sure that this issue had not already been reported.
[ ] I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
[X] I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
[X] I understand that support is provided by volunteer(s).

What happened?

When using a {fa fa-clock-o fa-lg} code (or any of the FontAwesome icons with a -o addition), the filter breaks these into unreadable HTML if you use activity names auto linking filter in addition to the FilterCodes filter.

What do you think should have happened?

All FontAwesome icons should be displayed properly, regardless if they contain the -o suffix like fa fa-clock-o

Steps to reproduce

Login as '...' (specify user role)
Go to '...'
Click on '....'
Scroll down to '....'
See error or issue. You get it?

Screenshots

Create a course Create a label containing the {fa fa-clock-o fa-lg} icon code and save Enable FilterCodes filter in the course and check to see if the code converts to the correct icon Enable Activity name auto linking filter in the course and check to see if the code is now broken

Moodle version

Moodle 3.11

Installed Moodle UI Language packs.

[ ] English only
[X] One or more other languages/regional dialects (specify below)
[ ] Other

If other language(s), please specify

NL, ES, DE, FR

Workaround

Use tags around the affected icons. This is quite labour intensive, though.

Additional information

No response

System information

Client Device type: Laptop Client Operating System: Windows 11, Mac OS Ventura Client Web Browser: Edge, Firefox for Mac Server Operating System: (e.g. Windows, Linux, Mac OS, Other - specify) Server Webserver: (e.g. Apache, Nginx, IIS, Other - specify) Server PHP: (e.g. 7.3, 7.4, 8.x, Other - specify)

Code of Conduct

[X] I have read and agree to the project's code of conduct.

michael-milette commented 1 year ago

Hi @joostelshoff ,

Thank you for reporting this issue. I will definitely look into this and get back to you.

Best regards,

Michael

michael-milette commented 1 year ago

Hi @joostelshoff ,

I followed your instructions on multiple versions of Moodle 3.x and 4.x including 3.11. There must be more to your instructions because I am unable to reproduce the issue you are experiencing.

Best regards,

Michael Milette

michael-milette commented 1 year ago

There has been no further response to the request for additional details in this ticket for over 2 months. I am therefore closing it for now. If you would like to resume working on it with me, please feel free to re-open the issue ticket.

Best regards,

Michael

michael-milette / moodle-filter_filtercodes