michael-milette / moodle-filter_filtercodes

FilterCodes filter for Moodle enables content creators to easily customize and personalize course and site content using plain text tags (no HTML). For premium support, contact us at https://www.tngconsulting.ca/contact
https://moodle.org/plugins/filter_filtercodes
GNU General Public License v3.0
30 stars 42 forks source link

Bug: Not displaying FilterCodes tags in side navigation #267

Closed bfriesenvcc closed 10 months ago

bfriesenvcc commented 10 months ago

Prerequisites

What happened?

In Moodle 4.1, Filtercodes are not displaying as intended on the Course index, when included in a Text and Media resource (previously called label).

What do you think should have happened?

I expected the name ("Blair" in this case) to show on the course index.

Steps to reproduce

  1. Login as some with editing access to a course
  2. Go to the course and add a Text and Media resource to any section of the course.
  3. Include a filtercode, such as firstname in the first few words of the T&MR and save the change.
  4. Open the course index and see how the label appears on the index.
  5. See how it appears as the filtercode and not what the filtercode should be showing.

Screenshots

filtercodes in course index

Moodle version

4.1.5 (2022112805)

Installed Moodle UI Language packs.

If other language(s), please specify

No response

Workaround

No response

Additional information

No response

System information

Client Device type: (e.g. Desktop, iPhone or iPad, Android phone or tablet, Other - specify) Client Operating System: (e.g. Windows, Linux, Mac OS, Android, iOS, Other - specify) Client Web Browser: (e.g. Chrome, Edge, Firefox, Safari, Safe Exam Browser, Moodle Mobile App) Server Operating System: (e.g. Windows, Linux, Mac OS, Other - specify) Server Webserver: (e.g. Apache, Nginx, IIS, Other - specify) Server PHP: (e.g. 7.3, 7.4, 8.x, Other - specify)

Code of Conduct

michael-milette commented 10 months ago

Hi @bfriesenvcc ,

I tested this out using Moodle 4.1 (original release) and Moodle 4.0.5+ (2022112805.08) and it works fine in both when using the Boost theme.

image image

There were actually a number of problems with the side navigation in earlier versions of Moodle 4.0 related to this and language switching but these have since been fixed.

If this is still a problem for you in recent releases of Moodle 4.1, I am pretty confident in saying that the problem is with the theme you are using. If the side navigation in your theme is based on early code from Moodle 4.0, it still contains the bug. I recommend that you contact the developer of your theme and ask them to fix it.

Alternatively, if it works like Moodle's Boost theme, labels don't show up in the navigation when Editing is turned off so it may be something you can live with.

Best regards,

Michael Milette

bfriesenvcc commented 10 months ago

Hmmm... we are using Boost. My apologies. I will have to investigate on our end. Good tip about the editing mode, though.

As always, thank you for your very valuable time, and this amazing plugin.