Bug: First video on page is gone after "FilterCodes" in ON globally

[caiadogithub]

Prerequisites

• [X] I'm reporting the issue to the correct repository.
• [X] I am running the latest version of this plugin (if not, please upgrade first).
• [X] I checked the README.md and Wiki documentation but did not find my answer.
• [X] I searched to make sure that this issue had not already been reported.
• [X] I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
• [X] I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
• [X] I understand that support is provided by volunteer(s).

What happened?

When "FilterCodes" is ON globally, first video is not visible

What do you think should have happened?

I expected all videos on page to be visible when "FilterCodes" is ON globally

Steps to reproduce

1. Login as 'admin'
2. Go to '/admin/filters.php'
3. Click on 'Filter Codes' and enable it.
4. Access any page with more than one YouTube URL
5. See error or issue.

Screenshots

No response

Moodle version

Moodle 3.11.16+

Installed Moodle UI Language packs.

• [ ] English only
• [X] One or more other languages/regional dialects (specify below)
• [ ] Other

If other language(s), please specify

EN, PT-BR

Workaround

No.

Additional information

No response

System information

Client Device type: Desktop Client Operating System: Ubuntu, Windows Client Web Browser: Chrome, Edge, Firefox Server Operating System: Ubuntu Server Webserver: Apache2 Server PHP: 7.4

Code of Conduct

• [X] I have read and agree to the project's code of conduct.

[michael-milette]

Hi @caiadogithub ,

I tested on both Moodle 3.11 and 4.0.3 but I could not reproduce the issue you described.

Could you share the HTML that you are using?

Best regards,

Michael

[caiadogithub]

Hi, @michael-milette

Here are the HTML codes from the pages where the first video is gone:

(1)

(2)

Ricardo ``

[michael-milette]

Hi @caiadogithub ,

I typed in your exact HTML code into Moodle 3.11 course Labels.

Works fine for me, with FilterCodes enabled and disabled.

The only thing I can suggest is that you go to Site Administrator > Plugins > Manage Filters and make sure that FilterCodes is at the top of the list of filters.

There is nothing in the HTML that you provided that would cause FilterCodes to have any effect on it. FilterCodes checks the content of the field for the occurence of a "{" character. If it doesn't find one, it does not process anything in the field. That said, if you are using FilterCodes elsewhere in the page, it could potentially affect it.

You could also try set debugging to DEVELOPER mode and check the box to show errors. This might reveal if there is a coding issue.

Unfortunately, based on the limited information that you have shared, I am not seeing the issue. Although the issue only appears when you enable FilterCodes, it could be a conflict with another plugin you have installed. The problem is, if I cannot reproduce the issue, I cannot fix it for you.

If you would like to consider premium support, I would be happy to troubleshoot your issue further by connecting to your website to determine what is going on. Just contact me through my website at https://www.tngconsulting.ca/contact.

Best regards,

Michael

[caiadogithub]

@michael-milette

"The only thing I can suggest is that you go to Site Administrator > Plugins > Manage Filters and make sure that FilterCodes is at the top of the list of filters."

It works now!!

Thanks!

Ricardo

[michael-milette]

HI @caiadogithub ,

Glad you got it working. Thanks for sharing the solution.

Best regards,

Michael Milette