Feature request: Add option to specify maximum size of QR Code

ralf-krause commented 5 months ago

Prerequisites

[X] I'm reporting the issue to the correct repository.
[X] I am running the latest version of this plugin (if not, please upgrade first).
[X] I checked the README.md and Wiki documentation but did not find my answer.
[X] I searched to make sure that this issue had not already been reported.
[ ] I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
[X] I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
[X] I understand that support is provided by volunteer(s).

What happened?

I wanted to show the FilterCodes for a QR-Code. The first line should show the FilterCode because I added the [brackets] around. The second line should show the QR code. The error is that both lines are showing the QR code and a documentation is not possible in Moodle 4.3. It works fine in Moodle 4.1.

[{qrcode}] https://mysite.org/course/view.php?id=45 [{/qrcode}] {qrcode} https://mysite.org/course/view.php?id=45 {/qrcode}

What do you think should have happened?

The documentation says the following:

Creating FilterCodes Documentation [{ }] : You can escape tags so they are not processed by adding [brackets] around the tag. Can be disabled in the plugin's settings if it causes you problems. [%7B %7D] : You can escape %7Bencoded%7D tags too so they are not processed by adding [brackets] around them.

Steps to reproduce

X

Screenshots

No response

Moodle version

Moodle 4.3.2+ (20240202)

Installed Moodle UI Language packs.

[ ] English only
[X] One or more other languages/regional dialects (specify below)
[X] Other

If other language(s), please specify

de, de_kids

Workaround

No response

Additional information

No response

System information

ipadOS 17.3, Safari browser Linux Debian 12 (Bookworm), Firefox browser 112 macOS 13.6, Safari browser, Chrome browser

Code of Conduct

[X] I have read and agree to the project's code of conduct.

ralf-krause commented 5 months ago

Could it be important that Moodle 4.3 runs with php 8.2.7 and Moodle 4.1 runs with php 7.4.6?

michael-milette commented 5 months ago

Hi @ralf-krause ,

Thank you for reporting this issue. It is unrelated to PHP 8.x. It was the result of a bug inadvertently introduced while I was optimizing FilterCodes performance for the release 2.4.3. If you would be so kind, I would be thankful if you could try the dev release 2.4.4 here on GitHub and let me know if that solves the problem for you. If it does, this fix will be included in the next release of FilterCodes.

Best regards,

Michael

ralf-krause commented 5 months ago

Hi Michael,

yes, the new dev version works for my. I tested two different qr codes … the first one was the qr code for "Hello World!" and the second one was the qr code for a Moodle course link "https://mysite.org/course/view.php?id=45". Both escape tags are looking fine in Moodle 4.3.2+ (20240202).

Best regards, Ralf

ralf-krause commented 5 months ago

I also tested the FilterCodes plugin 2.4.4dev with Moodle 4.4dev (20240202). The escape tag works fine.

michael-milette commented 5 months ago

Thanks for the feedback @ralf-krause . Glad I was able to resolve the issue for you. Much appreciated.

I will leave this issue open as a reminder to me for your request to have the option to specify a size.

Best regards,

Michael

michael-milette / moodle-filter_filtercodes