Bug: PHP Fatal error: Duplicate declaration of static variable $mycohorts in /var/www/moodle/filter/filtercodes/classes/text_filter.php on line 4311

mputzi commented 4 days ago

Prerequisites

[X] I'm reporting the issue to the correct repository.
[X] I am running the latest version of this plugin (if not, please upgrade first).
[X] I checked the README.md and Wiki documentation but did not find my answer.
[X] I searched to make sure that this issue had not already been reported.
[X] I have, or I know someone who has, the ability and willingness to test the fix on a Moodle LMS-based site.
[X] I am submitting no more than one bug report per issue ticket (please do not submit multiple bugs in one issue ticket).
[X] I understand that support is provided by volunteer(s).

What happened?

Upgrade of plugin stopped; site left unusable.

What do you think should have happened?

I expected the upgrade of the plugin to finish smoothly.

Steps to reproduce

Login as admin
Go to upgrade plugins
nothing happens, site not loading
Upgrading via cli
See fatal error message on console

Screenshots

No response

Moodle version

4.4.3 (Build: 20240902)

Installed Moodle UI Language packs.

[ ] English only
[X] One or more other languages/regional dialects (specify below)
[ ] Other

If other language(s), please specify

No response

Workaround

renaming variable in text_filter.php line 4311 and following lines of code block

Additional information

No response

System information

Client Device type: Desktop Client Operating System: Linux Client Web Browser: any Server Operating System: Linux Server Webserver: NGinx Server PHP: 8.3

Code of Conduct

[X] I have read and agree to the project's code of conduct.

jimsihk commented 4 days ago

Same error on Moodle 4.4.4 (Build: 20241007) and 4.5 (Build: 20241007), tried with a fresh copy of Moodle, can start up if disabled the filter. Once attempted to enable the filtercodes filter, Moodle will crash.

Issue happens since filtercode v2.6.0.

All0ne commented 4 days ago

Samoe error on Moodle 4.4.3+ (Build: 20240903) Issue happens with filtercode v2.6.0.

odelhaye commented 2 days ago

Same fatal error on Moodle 4.5 (Build: 20241007). Php 8.3.9.

michael-milette commented 2 days ago

Thank you for your contribution. The issue has been resolved and will be included in the next release of FilterCodes (which should be in a few minutes).

odelhaye commented 2 days ago

Ça fonctionne impec désormais. Merciii !

michael-milette / moodle-filter_filtercodes