search

michaelarnauts / home-assistant-comfoconnect

Home Assistant integration for Zehnder ComfoAir trough a Zehnder ComfoConnect LAN C.
Other
26 stars 13 forks source link

New naming convention #16

Closed roofburner closed 1 year ago

roofburner commented 1 year ago

Hi,

I installed the custom Home Assistant Zehnder ComfoAirQ integration (https://github.com/michaelarnauts/home-assistant-comfoconnect). I experienced the change in naming.

e.g. sensor.comfoairq_supply_humidity becomes sensor.supply_humidity

Is this a strategic decision? Why is the "comfoairq_" dropped?

I would like to keep the reference to the device providing the sensors.

e.g. sensor.openweathermap_humidity => sensor proviced by the OpenWeatherMap device.

In the new naming convention, the device reference gets lost.

Kind regards,

Stijn

michaelarnauts commented 1 year ago

Stijn,

This is not on purpose, but is a bug. I actually wanted to be able to do a migration based on the existing entities in case an update was done from the old comfoconnect component. This is something that has to be done when I want to merge the new component in Home Assistant core.

roofburner commented 1 year ago

OK, Michael. Is it OK to keep this ticket open until fixed? Maybe mark it as bug?

michaelarnauts commented 1 year ago

I had already mentioned this in issue #1, but I admit that it isn't really clear there :) I'll keep this issue open.

michaelarnauts commented 1 year ago

This has been fixed in https://github.com/michaelarnauts/home-assistant-comfoconnect/commit/bbeb267656dd78ea591d1c870128825517020f32

It's now using the _attr_has_entity_name = True property, so Home Assistant creates the correct entity_id.

roofburner commented 1 year ago

Dear Michael,

I have upgraded the Zehnder ComfoAirQ integration to a308546, but I still see sensors like sensor.outside_temperature. No reference in the name to ComfoAirQ. Do I miss something?

Kind regards..

roofburner commented 1 year ago

Real question: when will I be able to install bbeb267?

michaelarnauts commented 1 year ago

a308546 is the latest, and contains all the other fixes.

You probably don't see the new names since Home Assistant kept the existing IDs. I guess if you remove the integration and add it again, you'll get the new IDs.

roofburner commented 1 year ago

OK, Michael, I was confused about the numbering. I removed/added the integration. Now all sensors seem to have their correct name.

Thx!

michaelarnauts commented 1 year ago

OK, Michael, I was confused about the numbering. I removed/added the integration. Now all sensors seem to have their correct name.

Thx!

Yeah, I better had used real releases with a changelog, but then again, I actually want to merge all my changes back to Home Assistant. It's just that this also takes a lot of time and effort :(