search

michaelruocco / gradle-postman-runner

A gradle plugin to run Postman collections
MIT License
16 stars 13 forks source link

Added Gradle binding for Newman insecure flag #12

Closed lukacsd closed 4 years ago

lukacsd commented 4 years ago

Hey @michaelruocco, the config bindings are missing the setting to disable ssl cert checks, which I found useful in dealing with some test environments. This pull req is to help others with similar issues. Cheers, David

michaelruocco commented 4 years ago

Hi @lukacsd thanks for contributing this, it has highlighted an issue with my travis ci build script, which meant that it has tried to automatically release your pull request and failed. I believe I have addressed this now though.

I am also going to look up tidying up the tests I added, to make it easier to add a new test for this functionality. I will look at cleaning up the existing test and then adding a new test for this in the next week or so and then look to get this change merged.

Thanks again.

michaelruocco commented 4 years ago

@lukacsd just FYI I have created a new pull request which uses a flag named secure, rather than insecure. I have added some tests too, details are here: https://github.com/michaelruocco/gradle-postman-runner/pull/13 for this reason I am going to close this PR without merging, thanks for contributing the original idea!