Closed gstavrinos closed 5 years ago
I think we can leave it that way for a while and open another issue to polish this a little. Do you agree? @gstavrinos
Yes Michael, I think this is the correct approach. I have found some other problems and improvements, but I will make some new PRs when I am done.
Good work @gstavrinos thank you for the pull request! Hopefully, we fix this and be able to use this robot in ROS, when manufacturers decide to not support it.
Thank you too, Michael. I will keep working on this, along with a bug in rViz that I have encountered, and keep you updated!
These commits also include fixed names for controllers, corrected simulation and real hardware behaviour and more accurate simulation.
It has to be noted that:
Michael (@michtesar), please leave a review if you find any problems or you think that I should make any changes before merging.