search

mickael9 / fac

Command-line mod manager for Factorio (install, update...)
MIT License
50 stars 17 forks source link

AttributeError: 'ZippedMod' object has no attribute 'factorio_version' #8

Closed Arnavion closed 8 years ago

Arnavion commented 8 years ago

From clean start (fac remove '*'):

fac install boblogistics
fac install bobwarfare

The second one fails with

Traceback (most recent call last):
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\gtk-build\python-3.5\Win32\Scripts\fac.exe\__main__.py", line 9, in <module>
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\site-packages\fac\main.py", line 84, in main
    args.run(args)
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\site-packages\fac\commands\install.py", line 124, in run
    ignore_game_ver=args.ignore_game_ver):
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\site-packages\fac\mods.py", line 370, in resolve_local_requirement
    res = [mod for mod in self.find_mods(req.name)
  File "c:\programdata\chocolatey\lib\python3-x86_32\tools\lib\site-packages\fac\mods.py", line 372, in <listcomp>
    (ignore_game_ver or mod.factorio_version == game_ver)]
AttributeError: 'ZippedMod' object has no attribute 'factorio_version'

mod.factorio_version should be mod.game_version ?

mickael9 commented 8 years ago

Nice catch.

Funny thing is I downloaded the whole mod repository to test against that kind of errors. Too bad I did it with the -i flag...

zopieux commented 8 years ago

Not. Enough. Unittests.

mickael9 commented 8 years ago

You're welcome to write some :innocent: