microbiomedata / metadata-template-transformation

ETL between NMDC submission portal study records and user facility templates
0 stars 0 forks source link

Isotope label enumeration doesn't work with existing NMDC isotope slot #14

Open mslarae13 opened 1 year ago

mslarae13 commented 1 year ago

The NMDC slot 'isotope_exposure" can be used to inform the JGI template column "Isotope label".

In the JGI template, it's an enumeration (C13, N15, O18, Unlabeled).

NMDC doesn't have an enumeration & it is expected to include the compound that is labeled (13C glucose (C13 glucose), H218O, 15NH4+).

In theory, we can extrapolate the correct JGI enum from what we collection.. but it isn't easy, and it's error prone.

Looking for some comments / feedback on how we should handle this. @turbomam , @cmungall , @emileyfadrosh , @aclum

Some options:

aclum commented 1 year ago

I'd vote for 'Make isotope_exposure more general and enumerated to match JGI, assuming the chemical that is labeled will be captured somewhere else (chem administration?)' since it has more pros that the other option.