microservices-patterns / ftgo-application

Example code for the book Microservice patterns
Other
3.41k stars 1.32k forks source link

RestaurantJpaTest in Order Service is wrong #55

Closed asn25 closed 4 years ago

asn25 commented 4 years ago

Hi,

RestaurantJpaTest in integration-test module in Order Service is wrong. Seems a copy-paste bug. It contains 2 same transactions (save, save), but should contain second transaction as retrieve & assert, analogously with OrderJpaTest. At the current state RestaurantJpaTest will always return success (if DB is started), not doing actual test:

@Test public void shouldSaveRestaurant() { transactionTemplate.execute((ts) -> { Restaurant restaurant = new Restaurant(AJANTA_ID, AJANTA_RESTAURANT_NAME, AJANTA_RESTAURANT_MENU_ITEMS); restaurantRepository.save(restaurant); return null; }); transactionTemplate.execute((ts) -> { Restaurant restaurant = new Restaurant(AJANTA_ID, AJANTA_RESTAURANT_NAME, AJANTA_RESTAURANT_MENU_ITEMS); restaurantRepository.save(restaurant); return null; }); }