microservices-patterns / ftgo-application

Example code for the book Microservice patterns
Other
3.41k stars 1.32k forks source link

Why RestaurantService and OrderHistoryService have no "-contract" counterparts? #61

Open asn25 opened 4 years ago

asn25 commented 4 years ago

Hello,

main business services have a "-contract" service counterparts:

ftgo-accounting-service-contracts ftgo-consumer-service-contracts ftgo-kitchen-service-contracts ftgo-order-service-contracts

Why RestaurantService and OrderHistoryService don't have them? F.e., as it can be seen from Figure 9.6 in the book, the RestaurantService:

==========

BTW, there is an error in the book in Figure 9.6, page 300 - the arrow OrderService-RestaurantService communication should go to Restaurant Service since Restaurant Service is a Publisher and Order Service is a Subscriber (in the book the arrow goes to Order Service).

The same problem with arrow, probably, is with ConsumerService-AccountingService communication. Consumer Service is Publisher, AccountingService is Subscriber, so arrow should go to ConsumerService (in Fig. 9.6 arrow goes to AccountingService).

Also in OrderService-AccountingService command communication - arrow shoud go to AccountingService since it's a Replier, as I understand (in the book it goes to OrderService).