microsoft / ApplicationInsights-JS-Mezzurite

Application insights extension of Mezzurite
MIT License
9 stars 9 forks source link

Typescript Error when running npm run build out of the box #22

Open cn894 opened 5 years ago

cn894 commented 5 years ago

Steps followed:

  1. Cloned from master branch
  2. run npm install
  3. run npm run build

The build fails with the following error:

> @microsoft/applicationinsights-mezzurite@1.0.9 build C:\Users\caabreut.REDMOND\Desktop\ApplicationInsights-JS-Mezzurite
> npm run clean && tsc --p tsconfig.json && rollup -c && typedoc --out Doc

> @microsoft/applicationinsights-mezzurite@1.0.9 clean C:\Users\caabreut.REDMOND\Desktop\ApplicationInsights-JS-Mezzurite
> shx rm -rf _bundles dist dist-esm

src/Mezzurite.ts:114:7 - error TS2322: Type '{ name: string; url: string; }' is not assignable to type 'IPageViewPerformanceTelemetry'.
  Object literal may only specify known properties, and 'url' does not exist in type 'IPageViewPerformanceTelemetry'.

114       url:  url
          ~~~~~~~~~

Found 1 error.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @microsoft/applicationinsights-mezzurite@1.0.9 build: `npm run clean && tsc --p tsconfig.json && rollup -c && typedoc --out Doc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @microsoft/applicationinsights-mezzurite@1.0.9 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\caabreut.REDMOND\AppData\Roaming\npm-cache\_logs\2019-05-29T17_41_27_124Z-debug.log

I am unsure if this was caused by the revving of the AI SDK version or some other previous commit. Nonetheless, a broken build out of the box is not acceptable and we should have CICD in place to have caught it.

cn894 commented 5 years ago

This is referring to the current 1.x implementation