microsoft / ApplicationInsights-JS

Microsoft Application Insights SDK for JavaScript
MIT License
648 stars 240 forks source link

[BUG]AppInsights not working in IE7 #1142

Closed t525 closed 4 years ago

t525 commented 4 years ago

Description/Screenshot We are in the process of upgrading our pages to support multiple browsers. But, there are pages where we force compatibility to IE7. When we inject appinsight script into these pages, we get javascript syntax error. It would be appreciated if we can receive a workaround to get it working for our old pages until we roll out the new pages.

Steps to Reproduce

Expected behavior What's happening is that server requests are being logged but page views are not. We expect page view, user and session info to be logged. Additional context Add any other context about the problem here.

MSNev commented 4 years ago

I suspect your getting some form of JS exception being thrown. Can you load the dev tools (F12) and see what errors are appearing on the console?

And as a couple of side notes

We recently added ES3 support to allow the SDK to function on older browsers and in compatibility mode such as this... So you may want to consider upgrading -- but lets identify the error first.

t525 commented 4 years ago

Nev,

Can you please provide url of the JS that I should be using? I just get a generic syntax error which I don’t see if I remove compatibility mode. The error is somewhere in this code and it is not clear what is not compatible:

AppInsightCli.AppendLine("}({").Append($"instrumentationKey: "{ConfigurationManager.AppSettings["AppInsights.Key"]}"") .Append(",").AppendLine("disableCorrelationHeaders: false")

Thanks, Tim

Sent from my iPhone

On Dec 18, 2019, at 6:00 PM, Nev notifications@github.com<mailto:notifications@github.com> wrote:

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

I suspect your getting some form of JS exception being thrown. Can you load the dev tools (F12) and see what errors are appearing on the console?

And as a couple of side notes

We recently added ES3 support to allow the SDK to function on older browsers and in compatibility mode such as this... So you may want to consider upgrading -- but lets identify the error first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUPL57NDI6ID7PPQKATQZKTRRA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHY66I#issuecomment-567250809, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUIDIAT5BB36BR5X6QDQZKTRRANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

The version you are using is now considered to be "legacy" and will not have any changes like this fixed. As such to continue getting the latest code and therefore ES3 (IE7/8) support you will need to upgrade to the new version/snipet which is documented in the readme (which includes the new CDN URL). - https://github.com/microsoft/ApplicationInsights-JS#snippet-setup-ignore-if-using-npm-setup

On the error... If I'm decoding your c# correctly this looks like it resolves to something like this }({instrumentationKey: "<configured AppInsights.Key>" ,disableCorrelationHeaders: false});

Which is really the end of the snipet initialization (the pass the argments portion), so it could be any of the following

If you look at the end of the Readme, I've added a table of know ES3 incompatible JS functions which if used can cause this issue. And for any of your javascript you will also need to be aware of.

MSNev commented 4 years ago

Had some time so did a quick pass on the pasted snippet and it doesn't look like there are any ES3 usage issues, however, unless it's a copy/paste issue you do have something going on with quotes around this .url || "https://az416426.vo.msecnd.net/scripts/a/ai.0.js\", d.getElementsByTagName("script")[0].parentNode.appendChild(b) }); try { c.cookie = d.cookie

@ the end of the ai.0.js you have an escaped quote " \" ", but you are not escaping other quotes... It might be somthing around this where later versions handle this better than IE7...

t525 commented 4 years ago

This is what my javascript resolves to:

`

MSNev commented 4 years ago

Thanks, I've used this and found a couple of issues that needs to be fixed Issue 1)

Issue 2)

MSNev commented 4 years ago

As an expectation on timeframe, we won't get to or publish a fix for this until early 2020 as we are about to hit a lockdown period.

Can you try rolling back to your v1 usage and remove the const?

t525 commented 4 years ago

Thanks Nev, I think that might have done the trick. I am doing some testing to verify.

From: Nev [mailto:notifications@github.com] Sent: Thursday, December 19, 2019 2:25 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

As an expectation on timeframe, we won't get to or publish a fix for this until early 2020 as we are about to hit a lockdown period.

Can you try rolling back to your v1 usage and remove the const?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUJZJMRDXZLE2T5VZZDQZPC7DA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKVBFQ#issuecomment-567627926, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUOO77K6TFU6SQ5HSYLQZPC7DANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

The issue with the v2.3 is that we have not yet published the IE8 compatibility bits (v 2.3.1) to the CDN. I'm going to perform some additional validation now and we will publish the corrected bits in early Jan 2020.

MSNev commented 4 years ago

Version 2.3.1 does not throw and exceptions (during initialization) in IE7 and IE8 modes.

t525 commented 4 years ago

I will keep version 1 until 2.3 is added to CDN. I am noticing that not all page views are logged when user is using IE. When they switched to Edge, all page views are tracked.

MSNev commented 4 years ago

I suspect these are events associated with unload of the browser (especially for safari and idevices), this has been addressed as part of #1080 which will be in the version 2.4 or greater (I created a beta version of this yesterday but we only published the npm package), I suspect this will be the end of Jan (maybe Feb) before 2.4 is published to the CDN.

MSNev commented 4 years ago

We have now published v 2.3.1 to the CDN so https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js and https://az416426.vo.msecnd.net/scripts/b/ai.2.js now downloads v 2.3.1

So this should address the above errors on IE7/8

t525 commented 4 years ago

Nev,

Thanks. I gave it a try and I am getting couple of javascript errors. Below are errors and the script I am using on my pages. Am I doing something incorrectly in script?

SCRIPT5007: Unable to get property 'push' of undefined or null reference

SCRIPT438: Object doesn't support property or method 'defineProperty' File: ai.2.min.js, Line: 5, Column: 118792

From: Nev [mailto:notifications@github.com] Sent: Tuesday, January 07, 2020 5:09 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

We have now published v 2.3.1 to the CDN so https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js and https://az416426.vo.msecnd.net/scripts/b/ai.2.js now downloads v 2.3.1

So this should address the above errors on IE7/8

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUJVOBDAJZ2SE3ED6PDQ4T4PFA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKOVKY#issuecomment-571796139, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJTNE3EN5HKYDZQFJ3Q4T4PFANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Ok, there are 2 issues identified here. 1) 'push' undefined

t525 commented 4 years ago

I was able to clear out first issue. I miscopied something from github.

For second issue, it is failing in init.js and going to catch block:

// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. import { ApplicationInsightsContainer } from "./ApplicationInsightsContainer"; export { Initialization as ApplicationInsights } from "./Initialization"; "use strict"; // should be global function that should load as soon as SDK loads try { // E2E sku on load initializes core and pipeline using snippet as input for configuration // tslint:disable-next-line: no-var-keyword var aiName; if (typeof window !== "undefined" && typeof JSON !== "undefined") { // get snippet or initialize to an empty object aiName = window["appInsightsSDK"] || "appInsights"; if (window[aiName] !== undefined) { // this is the typical case for browser+snippet var snippet = window[aiName] || { version: 2.0 }; // overwrite snippet with full appInsights // for 2.0 initialize only if required if ((snippet.version === 2.0 && window[aiName].initialize) || snippet.version === undefined) { ApplicationInsightsContainer.getAppInsights(snippet, snippet.version); } } } } catch (e) { // TODO: Find better place to warn to console when SDK initialization fails if (console) { console.warn('Failed to initialize AppInsights JS SDK for instance ' + aiName + e.message); } } //# sourceMappingURL=Init.js.map

From: Nev [mailto:notifications@github.com] Sent: Wednesday, January 08, 2020 1:22 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Ok, there are 2 issues identified here.

  1. 'push' undefined

  2. The second is a problem with the way TypeScript or rollup is creating the module, while we appear to have fixed all of the ES3 issues in the script, at the very end of the module is the following line Object.defineProperty(exports, '__esModule', { value: true }); The issue is that IE7 doesn't implement "defineProperty" while IE8 defines it but may throw, so this issue is specific to IE7.... Will need to dig into this a bit deeper as using the F12 for IE11 in IE7 mode it appears that IE is not letting the script run (even though it should work).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUL3RYZFF3QRCMICPC3Q4YKVFA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINP2OA#issuecomment-572194104, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUMIMHSQJZ7GQ2PMPWDQ4YKVFANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Yes, I dug into it and identified the root cause as that final Object.defineProperty() which is added by rollup (used to create the modules at the point of packaging) so we are going to need to post process the generated files to "fixup" this issue and release a new version -- I expect it will be a few weeks before I'll get to and fix this problem.

MSNev commented 4 years ago

Version 2.4.3 is now published to CDN and NPM, this fixes the identified issues in this thread.

Note: If you are using / forcing IE7 mode you MUST also supply a JSON polyfil (before) App Insights is loaded otherwise app Insights will not be able to initialize.

t525 commented 4 years ago

Thanks. What’s good library to include for JSON polyfil?

From: Nev [mailto:notifications@github.com] Sent: Tuesday, February 04, 2020 2:56 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Version 2.4.3 is now published to CDN and NPM, this fixes the identified issues in this thread.

Note: If you are using / forcing IE7 mode you MUST also supply a JSON polyfil (before) App Insights is loaded otherwise app Insights will not be able to initialize.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUKKA7JJUZUFVYRGCBTRBHB4NA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKY7B4A#issuecomment-582086896, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJGDEM2XHXKFBKMTSLRBHB4NANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Here is one possible version (there are many) https://github.com/douglascrockford/JSON-js

t525 commented 4 years ago

Hi Nev,

I finally got to try your solution. I included JSON polyfil and updated the appinsight script that is injected onto page. However, the browser activity is still not being logged. Server activity is logged fine. Please let me know if I have something wrong in below script.

From: Nev notifications@github.com Sent: Tuesday, February 4, 2020 2:56 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Closed #1142https://github.com/microsoft/ApplicationInsights-JS/issues/1142.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUIZ2QQRT5CIAAZNH23RBHB4NA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWNBLSUY#event-3007494483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJGDEM2XHXKFBKMTSLRBHB4NANCNFSM4J4QWRFQ.

t525 commented 4 years ago

I realized I was still referencing version 2. Switched to 2.4.3 but still seeing the issue of page views not being logged.

From: Sorial, Timothy Sent: Saturday, February 29, 2020 12:33 PM To: 'microsoft/ApplicationInsights-JS' reply@reply.github.com Subject: RE: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

Hi Nev,

I finally got to try your solution. I included JSON polyfil and updated the appinsight script that is injected onto page. However, the browser activity is still not being logged. Server activity is logged fine. Please let me know if I have something wrong in below script.

From: Nev notifications@github.com<mailto:notifications@github.com> Sent: Tuesday, February 4, 2020 2:56 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com<mailto:ApplicationInsights-JS@noreply.github.com> Cc: Sorial, Timothy t.sorial@medpace.com<mailto:t.sorial@medpace.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Closed #1142https://github.com/microsoft/ApplicationInsights-JS/issues/1142.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142?email_source=notifications&email_token=AOCLWUIZ2QQRT5CIAAZNH23RBHB4NA5CNFSM4J4QWRF2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWNBLSUY#event-3007494483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJGDEM2XHXKFBKMTSLRBHB4NANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Hey, what do you mean by "page views not being logged"? When running in IE7 (or IE7 mode) the browser does not support the onhashchange event (which is what is used to track SPA page changes) as such NO automatic instrumentation will occur and there is no generic way that App Insights could do this (without causing issues). As such this is an unsupported feature for IE7.

You can however, still call trackPageView() yourself and this will attempt to send the requests to the server, I created a local script and ran it in IE7 mode to confirm that the request is "Attempted" so it will work.

What I mean by "Attempted" is that when running in IE7 mode my local file (file://T:/xxxx.html) is coming from the local domain, I have the script being fetched from "https://az416426.vo.msecnd.net/scripts/b/ai.2.js" (uncompressed published version) which then calls trackPageView() -- However, this fails because the XDomainRequest() fails because the page domain is not on the same protocol as the page (file / https). If you load the unminified version this is in the Sender.js around line 540 the code attempts to log a warning, however, again IE7 mode doesn't support console.log...

While AI "supports" ES3 mode (i.e. IE7/8) not all of the features will work, we will fix any JS error and you can manually call trackXXX methods and we will make sure the automatic traceException() continue. I believe this is stated in the readme.

Now in terms of IE7 mode, exactly why do you need to support IE7? As the total number of users still using IE7 is extremely low. I am aware that when you "host" (embed) a Browser control into your own application C# / C++ (ActiveX) by default every version of IE (including IE11) will run in IE7 mode.

However, you can change this default behavior by adding a meta tag to your returned HML page which will then run in the requested mode (if available), and if all these fail it will still default back to IE7 mode. This is one of the primary reasons why we are supporting and ES3 environment as we have customers internal to MS and external that have applications that run inside of hosted browsers and can't control the "real" version of the browser installed (Mostly because that are running really old (now unsupported) OS versions -- e.g. XP / ME etc)

The following links provide some good descriptions on the meta tags https://docs.microsoft.com/en-us/openspecs/ie_standards/ms-iedoco/380e2488-f5eb-4457-a07a-0cb1b6e4b4b5 https://stackoverflow.com/questions/26346917/why-use-x-ua-compatible-ie-edge-anymore

I should also add that when you use the following URL's for the script it actually picks up and uses the latest published version, so you don't need to pick a specific version https://az416426.vo.msecnd.net/scripts/b/ai.2.js https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js

And I was also just reminded that http reporting of events was also just disabled, so if you page it http the events will only be supported if sent to the https endpoint (which will probably also fail in IE7 / as XDomainRequest() doesn't like different protocols). We cannot fix or change this scenario as the AI JS team (this team) doesn't own the endpoint and this change was driven by security requirements.

t525 commented 4 years ago

Nev,

There are some pages which require forced compatibility to IE7 for them to work properly. Our app is quite large and we are in the process of trying to slowly convert these legacy pages so we don’t have to do forced compatibility.

When I inspect further, I am noticing Expected Identifier error when opening developer tools which I didn’t see before the upgrade. It is pointing to this injected script. Please let me know if I am doing anything incorrect in this script.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Sorial, Timothy Sent: Friday, March 20, 2020 9:04 AM To: microsoft/ApplicationInsights-JS reply@reply.github.com; microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

I just noticed that and removed it. However, I am getting long running script error in IE. I tried to open developer tools to inspect but couldn’t as the browser gets locked up. It seems like this only happens when the appinsight script is injected.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com<mailto:notifications@github.com> Sent: Thursday, March 19, 2020 3:40 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com<mailto:ApplicationInsights-JS@noreply.github.com> Cc: Sorial, Timothy t.sorial@medpace.com<mailto:t.sorial@medpace.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

You have an extra { here which IE 7 mode doesn't like, you will also need to watch out for missing ';' as IE 7/8 can get picky depending on what trails it.

return o}({{ instrumentationKey: "c1a84ccf-ed3a-4245-adfb-9ecbad40dc46",disableCorrelationHeaders: false });

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-601379933, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUITJI6GHBLYJP5H4EDRIJYJXANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

It took a bit of digging to find the problem, but this is an issue with the changes in 2.5.x and it's usage of dynamicProto() where the dynamicProto() is in an endless loop -- causing the long running script.

As a work around, you can change the url to this. https://az416426.vo.msecnd.net/scripts/b/ai.2.4.3.min.js

While I fix the dynamicProto component

MSNev commented 4 years ago

I've just rolled back the main ai.2.min.js script to version 2.4.4, so you shouldn't need to change the url anymore It could take up to 30 mins for all worldwide caches to pick up the change

MSNev commented 4 years ago

Created a new bug as there was a secondary issue that was also breaking IE7/8, so will fix both with the new issue [BUG] When running in IE7/8 the app insights doesn't initialize and gets stuck in a loop #1224

t525 commented 4 years ago

Thanks Nev. I think that resolved the error. Is there a reason why I am not seeing users being logged in Azure for my requests? I believe in version 1, this used to work.

[cid:image001.jpg@01D5FF6C.26FA5AF0]

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Friday, March 20, 2020 10:46 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Created a new bug as there was a secondary issue that was also breaking IE7/8, so will fix both with the new issue [BUG] When running in IE7/8 the app insights doesn't initialize and gets stuck in a loop #1224https://github.com/microsoft/ApplicationInsights-JS/issues/1224

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-601982626, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUMAOBZFDFE3KIAID33RIQS7NANCNFSM4J4QWRFQ.

t525 commented 4 years ago

Hi Nev,

Any update on this will be greatly appreciated.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Sorial, Timothy Sent: Saturday, March 21, 2020 10:33 AM To: microsoft/ApplicationInsights-JS reply@reply.github.com Subject: RE: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

Thanks Nev. I think that resolved the error. Is there a reason why I am not seeing users being logged in Azure for my requests? I believe in version 1, this used to work.

[cid:image002.jpg@01D601BA.DD9D32A0]

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com<mailto:notifications@github.com> Sent: Friday, March 20, 2020 10:46 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com<mailto:ApplicationInsights-JS@noreply.github.com> Cc: Sorial, Timothy t.sorial@medpace.com<mailto:t.sorial@medpace.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Created a new bug as there was a secondary issue that was also breaking IE7/8, so will fix both with the new issue [BUG] When running in IE7/8 the app insights doesn't initialize and gets stuck in a loop #1224https://github.com/microsoft/ApplicationInsights-JS/issues/1224

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-601982626, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUMAOBZFDFE3KIAID33RIQS7NANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Hi Tim,

I'm hoping to publish v2.5.3 either later tonight or tomorrow -- waiting on PR signoff.

Sorry I missed this question from above "Is there a reason why I am not seeing users being logged in Azure for my requests?"

We might need to look at a fiddler trace to see what's going on on the page, it may be some form of crossorigin or something...

Cheers

Nev

t525 commented 4 years ago

What I am finding is that user is being logged at server level but not browser level. So, I am not able to see the user browser/operating system info. How would you want me to capture the fiddler trace? Is there anything specific that I should be looking for?

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Tuesday, March 24, 2020 9:42 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Hi Tim,

I'm hoping to publish v2.5.3 either later tonight or tomorrow -- waiting on PR signoff.

Sorry I missed this question from above "Is there a reason why I am not seeing users being logged in Azure for my requests?"

We might need to look at a fiddler trace to see what's going on on the page, it may be some form of crossorigin or something...

Cheers

Nev

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-603593013, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUKG6YRTHSDPW5WVT2DRJFOPNANCNFSM4J4QWRFQ.

t525 commented 4 years ago

Nev,

I did some further debugging and found syntax error in the way I am sending telemetry. I was using aisdk.context.addTelemetryInitializer instead of aisdk.addTelemetryInitializer. Do you see any other glaring mistakes in below snippet:

window[aiName]=aisdk;aisdk.queue.push(function(){aisdk.addTelemetryInitializer(function (envelope) {var tags = envelope.tags;if (tags) {tags['ai.user.id'] = "t.sorial";} var telemetryItem = envelope.data.baseData;if (envelope.name == Microsoft.ApplicationInsights.Telemetry.PageView.envelopeType) {telemetryItem.name = "Daily Routine/Project Mgmt./Queries/Site Search";envelope.tags['ai.operation.name'] = telemetryItem.name;} telemetryItem.properties = telemetryItem.properties || {};telemetryItem.properties["portal"] = "Daily Routine";telemetryItem.properties["area"] = "Project Mgmt.";telemetryItem.properties["zone"] = "Queries";telemetryItem.properties["section"] = "Site Search";}); var serverId = "a4b660578acd9a498518129cd68a15a5";aisdk.context.operation.id = serverId;}); aisdk.trackPageView();

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Tuesday, March 24, 2020 9:42 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Hi Tim,

I'm hoping to publish v2.5.3 either later tonight or tomorrow -- waiting on PR signoff.

Sorry I missed this question from above "Is there a reason why I am not seeing users being logged in Azure for my requests?"

We might need to look at a fiddler trace to see what's going on on the page, it may be some form of crossorigin or something...

Cheers

Nev

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-603593013, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUKG6YRTHSDPW5WVT2DRJFOPNANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Nothing obvious, the only recomendation I would have is around adding some additional checks for the following line, as this could evaluate to undefined depending on the source of the telemetry (e.g. for example a cross origin exception doesn't (currently) populate the envelope.data.baseData so this would block all exceptions of this type from being sent to the server) var telemetryItem = envelope.data.baseData; So either of these would work var data = envelelope.data = envelelope.data || {}; var telemetryItem = data.baseData = data.baseData || {}

where this both assigns the local variable and the embedded envelope data with either the target (itself) or the new empty object.

Cheers

Nev

t525 commented 4 years ago

I made the recommended change and found no difference in behavior. This is what I am seeing. Server requests are being logged fine but user info is not. Notice upper portion is missing region, operating system, and browser info. Not sure why the telemetry on the client side is not being sent.

[cid:image001.jpg@01D602AA.D37AE1F0]

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Wednesday, March 25, 2020 1:20 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Nothing obvious, the only recomendation I would have is around adding some additional checks for the following line, as this could evaluate to undefined depending on the source of the telemetry (e.g. for example a cross origin exception doesn't (currently) populate the envelope.data.baseData so this would block all exceptions of this type from being sent to the server) var telemetryItem = envelope.data.baseData; So either of these would work var data = envelelope.data = envelelope.data || {}; var telemetryItem = data.baseData = data.baseData || {}

where this both assigns the local variable and the embedded envelope data with either the target (itself) or the new empty object.

Cheers

Nev

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-603973008, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJM3UG2D5X6I4QUO6LRJI4NZANCNFSM4J4QWRFQ.

t525 commented 4 years ago

I noticed this note regarding breaking change for version 2 upgrade:

Moved context.operation to context.telemetryTrace. Some fields were also changed (operation.id --> telemetryTrace.traceID)

I tried this with my aisdk object below but there is no properties object for this one. Am I missing something or is this under telemetryItem object?

Below is modified script:

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Wednesday, March 25, 2020 1:20 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Nothing obvious, the only recomendation I would have is around adding some additional checks for the following line, as this could evaluate to undefined depending on the source of the telemetry (e.g. for example a cross origin exception doesn't (currently) populate the envelope.data.baseData so this would block all exceptions of this type from being sent to the server) var telemetryItem = envelope.data.baseData; So either of these would work var data = envelelope.data = envelelope.data || {}; var telemetryItem = data.baseData = data.baseData || {}

where this both assigns the local variable and the embedded envelope data with either the target (itself) or the new empty object.

Cheers

Nev

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-603973008, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJM3UG2D5X6I4QUO6LRJI4NZANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Hi Tim,

I don't have the history from the v1 -> v2 updates, but I grabbed your code and added some additional logging to see what was happening and ran it locally in edge, IE and IE in 7 emulation mode and it looks like the properties are present and it is populating the correct location (as far as I currently know)

This shows that the aisdk.properties.context object exists and is being populated and during the telemetry initializer the value assigned for the traceId is populated.

The new location for the values is located in the traceId == envelope.ext.trace.traceId user == envelope.ext.user.id

While the console.log is not showing anything in the tags [] looking at the network request that is sent it does include the values set. And when running in IE7 mode and debugging into the packaging the tags are also set.

So I think it looks ok... I've also just released v2.5.3 with the IE7 fix to the CDN, so these tests where done with that version,

context:{"sessionManager":{"logger":{"queue":[],"AIInternalMessagePrefix":"AITR","_messageCount":0,"_messageLogged":{}},"config":{},"automaticSession":{}},"application":{},"device":{"id":"browser","deviceClass":"Browser"},"internal":{"sdkVersion":"javascript:2.5.3"},"location":{},"user":{"isNewUser":true,"logger":{"queue":[],"AIInternalMessagePrefix":"AITR","_messageCount":0,"_messageLogged":{}},"config":{},"id":"7naqk","accountAcquisitionDate":"2020-03-25T19:19:49.586Z","accountId":null},"telemetryTrace":{"traceID":"ed81555338e9324393867494f2536b24","name":"/T:/IE7_Error.local.html"},"session":{}} IE7_Error.local.html:38 envelope:{"name":"Microsoft.ApplicationInsights.{0}.Pageview","time":"2020-03-25T19:19:49.698Z","iKey":"711858ea-f0e0-4ee9-9ddb-5b8a9b79392f","ext":{"device":{"localId":"browser","deviceClass":"Browser"},"user":{"id":"7naqk"},"app":{"sesId":"USyNi"},"trace":{"traceID":"ed81555338e9324393867494f2536b24","name":"/T:/IE7_Error.local.html"}},"tags":[],"data":{"duration":29.27500003715977},"baseType":"PageviewData","baseData":{"name":"","uri":"file:///T:/IE7_Error.local.html","refUri":""},"ver":"4.0"} IE7_Error.local.html:38 envelope:{"name":"Microsoft.ApplicationInsights.{0}.PageviewPerformance","time":"2020-03-25T19:19:49.702Z","iKey":"711858ea-f0e0-4ee9-9ddb-5b8a9b79392f","ext":{"device":{"localId":"browser","deviceClass":"Browser"},"user":{"id":"7naqk"},"app":{"sesId":"USyNi"},"trace":{"traceID":"ed81555338e9324393867494f2536b24","name":"/T:/IE7_Error.local.html"}},"tags":[],"data":{"duration":29.27500003715977},"baseType":"PageviewPerformanceData","baseData":{"name":"","uri":"file:///T:/IE7_Error.local.html","isValid":true,"durationMs":29.27500003715977,"duration":"00:00:00.029","perfTotal":"00:00:00.029","networkConnect":"00:00:00.000","sentRequest":"00:00:00.000","receivedResponse":"00:00:00.007","domProcessing":"00:00:00.021"},"ver":"4.0"} IE7_Error.local.html:38 envelope:{"name":"InternalMessageId: 72","iKey":"711858ea-f0e0-4ee9-9ddb-5b8a9b79392f","time":"2020-03-25T19:19:59.597Z","baseType":"MessageData","baseData":{"message":"AI (Internal): 72 message:\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/82.0.4080.0 Safari/537.36 Edg/82.0.453.2\""},"ver":"4.0","tags":[],"ext":{"device":{"localId":"browser","deviceClass":"Browser"},"user":{"id":"7naqk"},"app":{"sesId":"USyNi"},"trace":{"traceID":"ed81555338e9324393867494f2536b24","name":"/T:/IE7_Error.local.html"}}}

var sdkInstance="appInsightsSDK"; window[sdkInstance]="appInsights"; var aiName=window[sdkInstance],aisdk=window[aiName]||function(n){var o={config:n,initialize:!0},t=document,e=window,i="script"; setTimeout(function(){var e=t.createElement(i); e.src=n.url||"https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js",t.getElementsByTagName(i)[0].parentNode.appendChild(e)}); try{o.cookie=t.cookie}catch(e){}function a(n){o[n]=function(){var e=arguments; o.queue.push(function(){o[n].apply(o,e)})}}o.queue=[],o.version=2; for(var s=["Event","PageView","Exception","Trace","DependencyData","Metric","PageViewPerformance"];s.length;)a("track"+s.pop()); var r="Track",c=r+"Page"; a("start"+c),a("stop"+c); var u=r+"Event"; if(a("start"+u),a("stop"+u),a("addTelemetryInitializer"),a("setAuthenticatedUserContext"),a("clearAuthenticatedUserContext"),a("flush"),o.SeverityLevel={Verbose:0,Information:1,Warning:2,Error:3,Critical:4},!(!0===n.disableExceptionTracking||n.extensionConfig&&n.extensionConfig.ApplicationInsightsAnalytics&&!0===n.extensionConfig.ApplicationInsightsAnalytics.disableExceptionTracking)){a(""+(s="onerror")); var p=e[s]; e[s]=function(e,n,t,i,a){var r=p&&p(e,n,t,i,a); return!0!==r&&o[""+s]({message:e,url:n,lineNumber:t,columnNumber:i,error:a}),r},n.autoExceptionInstrumented=!0}return o}({instrumentationKey: "711858ea-f0e0-4ee9-9ddb-5b8a9b79392f",disableCorrelationHeaders: false}); window[aiName]=aisdk; aisdk.queue.push(function(){ aisdk.addTelemetryInitializer(function (envelope) { var tags = envelope.tags; if (tags) {tags['ai.user.id'] = "t.sorial";} var data = envelope.data || {}; var telemetryItem = data.baseData || {}; if (envelope.name == Microsoft.ApplicationInsights.Telemetry.PageView.envelopeType) { telemetryItem.name = "123Emily/Setup/Rule/Conditional Reporting & Alert"; envelope.tags['ai.operation.name'] = telemetryItem.name; } telemetryItem.properties = telemetryItem.properties || {}; telemetryItem.properties["portal"] = "123Emily"; telemetryItem.properties["area"] = "Setup"; telemetryItem.properties["zone"] = "Rule"; telemetryItem.properties["section"] = "Conditional Reporting & Alert"; try { var values = JSON.stringify(envelope); console && console.log && console.log("envelope:" + values); } catch (e) { console && console.log && console.log("error:" + e); } }); var serverId = "ed81555338e9324393867494f2536b24"; aisdk.properties.context.telemetryTrace.traceID = serverId; try { var values = JSON.stringify(aisdk.properties.context); console && console.log && console.log("context:" + values); } catch (e) { console && console.log && console.log("error:" + e); } }); aisdk.trackPageView()

t525 commented 4 years ago

Nev,

I am seeing infinite loop issue again after the recent update. When I deploy this to production, I don’t want to risk something breaking due to updates. Do you suggest I host the file instead of using the CDN? What is recommended?

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Wednesday, March 25, 2020 1:20 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Nothing obvious, the only recomendation I would have is around adding some additional checks for the following line, as this could evaluate to undefined depending on the source of the telemetry (e.g. for example a cross origin exception doesn't (currently) populate the envelope.data.baseData so this would block all exceptions of this type from being sent to the server) var telemetryItem = envelope.data.baseData; So either of these would work var data = envelelope.data = envelelope.data || {}; var telemetryItem = data.baseData = data.baseData || {}

where this both assigns the local variable and the embedded envelope data with either the target (itself) or the new empty object.

Cheers

Nev

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-603973008, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJM3UG2D5X6I4QUO6LRJI4NZANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Hi Tim,

I'm not seeing the infinite loop issue with 2.5.3... I've tested multiple times locally on this.

Can you change the url to the non-minified version, run it in the debugger (F12) and when it gets stuck in the loop press the pause link https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js => https://az416426.vo.msecnd.net/scripts/b/ai.2.js

In normal situations it will be running the setInterval() for polling the queue each 10 seconds, but this is not the loop / deadlock issue...

I did have 1 case where it seemed to lockup, but I just forced (Ctrl-F5) the current version to be re-fetched from the CDN rather than using the local cached version of the older release

MSNev commented 4 years ago

And to answer the questions (sorry missed that in previous response).

Do you suggest I host the file instead of using the CDN? What is recommended? It's recommended that you use the CDN as this means

The only real advantage of hosting on your own domain is that browsers don't need to perform the DNS lookup fir the different domain, however, browsers have limits in the number of connections (resources) they can download per domain, so multiple domains can actually help -- depending on the users bandwidth and where they are fetching the resources from.

t525 commented 4 years ago

The IE browser just locks up and I am unable to debug. This morning I wasn’t having these issues. It seems like after the update was pushed, something went wrong.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Wednesday, March 25, 2020 4:20 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Hi Tim,

I'm not seeing the infinite loop issue with 2.5.3... I've tested multiple times locally on this.

Can you change the url to the non-minified version, run it in the debugger (F12) and when it gets stuck in the loop press the pause link https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js => https://az416426.vo.msecnd.net/scripts/b/ai.2.js

In normal situations it will be running the setInterval() for polling the queue each 10 seconds, but this is not the loop / deadlock issue...

I did have 1 case where it seemed to lockup, but I just forced (Ctrl-F5) the current version to be re-fetched from the CDN rather than using the local cached version of the older release

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-604064596, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUJBQHYNUHR2I6GEBTTRJJRN3ANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

What version is it showing at the top of the file, it should be 2.5.3, version 2.5.2 had the issue...

https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js /*!

MSNev commented 4 years ago

Another question, when the browser locks up is IE doing a bunch of CPU usage? I just checked locally with IE11 running in IE7 compat mode and it's working fine. Even when the previous version had the issue I found the browser itself didn't lock up it just burnt ~15% CPU and the debugger pause still worked (at least for me)

t525 commented 4 years ago

Nev,

I switched version to 2.4.4 and the browser no longer locks. So, that tells me that something is going with version 2.5.x.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com Sent: Wednesday, March 25, 2020 5:39 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Another question, when the browser locks up is IE doing a bunch of CPU usage? I just checked locally with IE11 running in IE7 compat mode and it's working fine. Even when the previous version had the issue I found the browser itself didn't lock up it just burnt ~15% CPU and the debugger pause still worked (at least for me)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-604101670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUPILOC4ZX7EHBMM3F3RJJ2XFANCNFSM4J4QWRFQ.

t525 commented 4 years ago

Nev,

I am also noticing that for cases where page views are logged, the custom properties are not being set. Below is the way I am setting the properties. Did this change for version 2 as well? Also, I know you mentioned before that there is an issue with IE7 logging page views. Is there a workaround that can be done in the meantime until we get all of our pages converted?

aisdk.addTelemetryInitializer(function (envelope) {var tags = envelope.tags;if (tags) {tags['ai.user.id'] = "t.sorial";}var data = envelope.data || {};var telemetryItem = data.baseData || {};if (envelope.name == Microsoft.ApplicationInsights.Telemetry.PageView.envelopeType) {telemetryItem.name = "_Matt-3/Setup/Subject Binder/Subject ID Format";envelope.tags['ai.operation.name'] = telemetryItem.name;}telemetryItem.properties = telemetryItem.properties || {};telemetryItem.properties["portal"] = "_Matt-3";telemetryItem.properties["area"] = "Setup";telemetryItem.properties["zone"] = "Subject Binder";telemetryItem.properties["section"] = "Subject ID Format";});var serverId = "d871d213250e664fb58560a247513d88";aisdk.properties.context.telemetryTrace.traceID = serverId;});

Thanks,

Tim Sorial

Sr. Software Engineer

From: Sorial, Timothy Sent: Thursday, March 26, 2020 8:50 AM To: 'microsoft/ApplicationInsights-JS' reply@reply.github.com Subject: RE: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

Nev,

I switched version to 2.4.4 and the browser no longer locks. So, that tells me that something is going with version 2.5.x.

Thanks,

Tim Sorial

Sr. Software Engineer

From: Nev notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, March 25, 2020 5:39 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com<mailto:ApplicationInsights-JS@noreply.github.com> Cc: Sorial, Timothy t.sorial@medpace.com<mailto:t.sorial@medpace.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)

This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.

Another question, when the browser locks up is IE doing a bunch of CPU usage? I just checked locally with IE11 running in IE7 compat mode and it's working fine. Even when the previous version had the issue I found the browser itself didn't lock up it just burnt ~15% CPU and the debugger pause still worked (at least for me)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-604101670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUPILOC4ZX7EHBMM3F3RJJ2XFANCNFSM4J4QWRFQ.

MSNev commented 4 years ago

Hi Tim,

I'll try and answer your question, if I miss one just ping me again on it, but first a couple of questions from me.

Now to answer the questions Page Views

Custom Properties