t525
commented
4 years ago Hi Nev,
It locks up in version 2.5.2 as well. 2.5.2 throws long run script error. For 2.5.3, the browser just hangs on loading page and doesn’t respond.
I am running IE11 with forced compatibility to IE7. Runtime environment is 64 bit, windows 10.
Do you have an example of how custom property can be set with the new version? I am trying to make sure I have the syntax correct.
Thanks,
Tim Sorial
Sr. Software Engineer
From: Nev notifications@github.com Sent: Thursday, March 26, 2020 1:33 PM To: microsoft/ApplicationInsights-JS ApplicationInsights-JS@noreply.github.com Cc: Sorial, Timothy t.sorial@medpace.com; Author author@noreply.github.com Subject: Re: [microsoft/ApplicationInsights-JS] [BUG]AppInsights not working in IE7 (#1142)
This message was sent from outside the company. Please use caution when opening attachments or clicking any links in the email.
Hi Tim,
I'll try and answer your question, if I miss one just ping me again on it, but first a couple of questions from me.
- Was it downloading v 2.5.3 and still locking up with that version (as opposed to 2.5.2)
- What is the runtime environment XP, 32 or 64 and assuming native IE 7 (not IE 11 running in emulation mode -- as I can no longer repro in this mode)? I want to spend a little bit of time trying to repro to find the issue if I can as we don't have the infrastructure to create hotfixes from older builds and the changes introduced in 2.5 will be further extended so I don't want to compound any issues.
Now to answer the questions Page Views
- Assuming you are talking about local SPA (updating the url with '#' arguments) then there is no automatic solution as IE 7/8 doesn't support the onhashchange event. Your only option here is to add manual event firing (perhaps with just track) when you are manually changing the page view (in your controller / route manager -- depending on your JS framework).
Custom Properties
- As I'm not familiar with the locations in v1, I'm just looking at the current code and looking at the ITelemetryItem interface the answer looks like - yes, custom properties look like they are now on the data field (https://github.com/microsoft/ApplicationInsights-JS/blob/master/shared/AppInsightsCore/src/JavaScriptSDK.Interfaces/ITelemetryItem.ts)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-JS/issues/1142#issuecomment-604569181, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLWUOOL5OEN5T6HSPDJBDRJOGTFANCNFSM4J4QWRFQ.
MSNev
rajithagarapati
github-actions[bot]
Description/Screenshot We are in the process of upgrading our pages to support multiple browsers. But, there are pages where we force compatibility to IE7. When we inject appinsight script into these pages, we get javascript syntax error. It would be appreciated if we can receive a workaround to get it working for our old pages until we roll out the new pages.
Steps to Reproduce
How you initialized the SDK: We are using below code to inject the appinsight script: StringBuilder AppInsightCli = new StringBuilder(); AppInsightCli.Append("<script type=\"text/javascript\">"); AppInsightCli.Append("var appInsights = window.appInsights || function (a) {"); AppInsightCli.Append("function b(a) { c[a] = function () { var b = arguments; c.queue.push(function () { c[a].apply(c, b) }) } } var c = { config: a }, d = document, e = window; setTimeout(function () { var b = d.createElement(\"script\"); b.src = a.url || \"https://az416426.vo.msecnd.net/scripts/a/ai.0.js\", d.getElementsByTagName(\"script\")[0].parentNode.appendChild(b) }); try { c.cookie = d.cookie } catch (a) { } c.queue = []; for (var f = [\"Event\", \"Exception\", \"Metric\", \"PageView\", \"Trace\", \"Dependency\"]; f.length;)b(\"track\" + f.pop()); if (b(\"setAuthenticatedUserContext\"), b(\"clearAuthenticatedUserContext\"), b(\"startTrackEvent\"), b(\"stopTrackEvent\"), b(\"startTrackPage\"), b(\"stopTrackPage\"), b(\"flush\"), !a.disableExceptionTracking) { f = \"onerror\", b(\"\" + f); var g = e[f]; e[f] = function (a, b, d, e, h) { var i = g && g(a, b, d, e, h); return !0 !== i && c[\"\" + f](a, b, d, e, h), i } } return c"); AppInsightCli.AppendLine("}({").Append($"instrumentationKey: \"{ConfigurationManager.AppSettings["AppInsights.Key"]}\"") .Append(",").AppendLine("disableCorrelationHeaders: false") .AppendLine("});"); AppInsightCli.Append("window.appInsights = appInsights;"); AppInsightCli.Append("appInsights.queue.push(function(){"); AppInsightCli.Append("appInsights.context.addTelemetryInitializer(function (envelope) {"); AppInsightCli.Append("const tags = envelope.tags;"); AppInsightCli.Append("if (tags) {"); AppInsightCli.Append($"tags['ai.user.id'] = \"{HttpContext.Current.User.Identity.Name.Split(new string[] { "\" }, StringSplitOptions.RemoveEmptyEntries).Last()}\";").AppendLine("}"); AppInsightCli.Append("var telemetryItem = envelope.data.baseData;"); AppInsightCli.Append("if (envelope.name == Microsoft.ApplicationInsights.Telemetry.PageView.envelopeType) {"); AppInsightCli.Append($"telemetryItem.name = \"{requestName}\";"); AppInsightCli.Append($"envelope.tags['ai.operation.name'] = telemetryItem.name;"); AppInsightCli.AppendLine("}"); AppInsightCli.Append("telemetryItem.properties = telemetryItem.properties || {};"); AppInsightCli.Append($"telemetryItem.properties[\"portal\"] = \"{psetting.PortalName}\";"); AppInsightCli.Append($"telemetryItem.properties[\"area\"] = \"{psetting.ActiveArea.AreaName}\";"); AppInsightCli.Append($"telemetryItem.properties[\"zone\"] = \"{psetting.ActiveZone.ZoneName}\";"); AppInsightCli.Append($"telemetryItem.properties[\"section\"] = \"{psetting.ActiveSection.SectionName}\";");
Expected behavior What's happening is that server requests are being logged but page views are not. We expect page view, user and session info to be logged. Additional context Add any other context about the problem here.