powershell scripts do not terminate correctly

[KnicKnic]

@vishiy @rashmichandrashekar I am using https://github.com/microsoft/OMS-docker/blob/ci_feature_prod/docs/aks/mdmonboarding/mdm_onboarding.ps1 I noticed that it exits incorrectly using exit This sets the exit code to 0 and allows apps to continue.

You should either throw, or use exit 1 or something else. See https://devblogs.microsoft.com/powershell/windows-powershell-exit-codes/

I was expecting when the scrip failed, to fail my script runner.

[austonli]

Hi @KnicKnic , we are working on a feature to remove the dependency for the Metrics role assignments. At that point, we will not longer require that script. Please let us know if this is still a blocking issue for you.

[KnicKnic]

@austonli I think the problem is endemic in the code base and all powershell files should be reviewed. I found a similar pattern in the second powershell file I looked at https://github.com/microsoft/OMS-docker/blob/ci_feature_prod/docs/aksengine/kubernetes/AddMonitoringWorkspaceTags.ps1