search

microsoft / glTF-Toolkit

A collection of tools for modifying and optimizing glTF assets
MIT License
295 stars 41 forks source link

NDEBUG missing from Release configuration? #29

Closed marpe closed 6 years ago

marpe commented 6 years ago

Hi,

Shouldn't NDEBUG be set for Release builds?

https://github.com/Microsoft/glTF-Toolkit/blob/ee37a890c2cdcc20656d2ff3517332a815279965/glTF-Toolkit/glTF-Toolkit.vcxproj#L123

We're getting artifacts in our output when running in software mode otherwise (there seem to be some issues using a WARP device)

robertos commented 6 years ago

Yep, looks like a mistake when the project was consolidated (FYI @benbuzbee). Feel free to submit a PR if you have the bandwidth. Thanks!