search

microsoft / glTF-Toolkit

A collection of tools for modifying and optimizing glTF assets
MIT License
295 stars 41 forks source link

Add a Specular Glossiness to Metallic Roughness conversion step to workflows. #36

Closed najadojo closed 6 years ago

najadojo commented 6 years ago

Add a Specular Glossiness to Metallic Roughness conversion step to workflows. Refactored texture loading and packing utils into generic textures utils. Resolved packing, resizing and compressing texture issues with sRGB and alpha channels. Update draco build to allow for ARM.

Also includes #34 and #35.

najadojo commented 6 years ago

Did you have a collection of test assets that are typically used?

robertos commented 6 years ago

I start with all the gltf samples, that's a quick and easy litmus test. I also use a few assets from actual apps, and more recently I've been using a few from Poly, Remix3D and some environments. If you need help I can send some assets on Monday.

Roberto

From: Jamie Marconi notifications@github.com Sent: Saturday, July 7, 2018 1:09:28 PM To: Microsoft/glTF-Toolkit Cc: Roberto Sonnino; Comment Subject: Re: [Microsoft/glTF-Toolkit] Add a Specular Glossiness to Metallic Roughness conversion step to workflows. (#36)

Did you have a collection of test assets that are typically used?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FglTF-Toolkit%2Fpull%2F36%23issuecomment-403240082&data=02%7C01%7Crobertos%40microsoft.com%7C04f43b40f8ed4a00e7db08d5e4458c0c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636665909710895142&sdata=PeeD%2BaOCwIJaCpB2WnCyRdCgRwddH8BSGq3LaLCZ6eQ%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAl8Brq4ALwcProISSai9VpgPwJWbr_qks5uERV4gaJpZM4VGK_0&data=02%7C01%7Crobertos%40microsoft.com%7C04f43b40f8ed4a00e7db08d5e4458c0c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636665909710895142&sdata=jmjt7PoZxr4rhKp1AevmfHgb4%2FSGoc5sggicEXdXK7w%3D&reserved=0.

robertos commented 6 years ago

@najadojo Let me know if I can help you to complete this PR - lots of goodness here :)

najadojo commented 6 years ago

I haven't completed testing these changes yet and I've been moved on to other work... I'll try and finish that up in my free time.

najadojo commented 6 years ago

@Dharnidharka this last commit will fix #39, using mesh compressed assets as input. You can grab a release binary on the artifacts page.

najadojo commented 6 years ago

@robertos this PR is ready for merging.

Dharnidharka commented 6 years ago

@najadojo Thank you for the fix :)