Perform material processing after lod merging to fix share material comparison

microsoft / glTF-Toolkit

A collection of tools for modifying and optimizing glTF assets

MIT License

295 stars 41 forks source link

Perform material processing after lod merging to fix share material comparison #45

Closed marpe closed 5 years ago

marpe commented 5 years ago

The comparison of materials went bonkers when merging lods with the -share-materials flag when top level materials are converted to metal roughness. This compromise is still far from optimal, but I can't think of a better solution off the top of my head :/

najadojo commented 5 years ago

What do you mean by bonkers? Removing specGloss can be an optional step in a consumer's workflow I don't think its prudent to remove this comparison.

marpe commented 5 years ago

Well I have 3 LODs I want to merge but since the spec gloss in top level materials are removed the comparison fails