microsoft / semantic-link-labs

Early access to new features for Microsoft Fabric's Semantic Link.
MIT License
178 stars 37 forks source link

Typo in sempy_labs.report.clone_report() #119

Closed patryksitarek closed 2 months ago

patryksitarek commented 2 months ago

Describe the bug I found a bug in the sempy_labs.report.clone_report method. When defining all parameters, I get an exception KeyError: 'Dataset Id'. The error message is pointing to src/sempy_labs/report/_report_functions.py file, line 475 "target_dataset_id = dfD_filt["Dataset Id"].iloc[0]".

Probably it's just a typo. A few lines above, the fabric.list_reports() method is called, which contains the 'Dataset ID' column, instead of 'Dataset Id'.

To Reproduce Steps to reproduce the behavior:

  1. Call sempy_labs.report.clone_report() method with all args determined.
  2. See error

Expected behavior Report to be cloned.

Environment

m-kovalsky commented 2 months ago

Thanks for reporting. I have a pending PR to improve this function which resolves this issue as well.


From: Patryk Sitarek @.> Sent: Tuesday, September 3, 2024 4:50:05 PM To: microsoft/semantic-link-labs @.> Cc: Subscribed @.***> Subject: [microsoft/semantic-link-labs] Typo in sempy_labs.report.clone_report() (Issue #119)

Describe the bug I found a bug in the sempy_labs.report.clone_report method. When defining all parameters, I get an exception KeyError: 'Dataset Id'. The error message is pointing to src/sempy_labs/report/_report_functions.py file, line 475 "target_dataset_id = dfD_filt["Dataset Id"].iloc[0]".

Probably it's just a typo. A few lines above, the fabric.list_reports() method is called, which contains the 'Dataset ID' column, instead of 'Dataset Id'.

To Reproduce Steps to reproduce the behavior:

  1. Call sempy_labs.report.clone_report() method with all args determined.
  2. See error

Expected behavior Report to be cloned.

Environment

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/semantic-link-labs/issues/119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHBQBNQGHS5JEL372YE23KTZUW5A3AVCNFSM6AAAAABNSGDOZKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDEOJTHA4TCOI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

m-kovalsky commented 2 months ago

Fixed in 0.7.3.