search

microsoft / semantic-link-labs

Early access to new features for Microsoft Fabric's Semantic Link.
MIT License
178 stars 37 forks source link

Incorrect Description in BPA Rules for rule "Visible objects with no description" #225

Closed thedaxshepherd closed 3 weeks ago

thedaxshepherd commented 1 month ago

Describe the bug In the _model _bpa_rules.py file, an incorrect description is assigned to one of the rules. The rule "Visible objects with no description" has the description of "Calculation groups have no function unless they have calculation items." This belongs to the rule "Calculation groups with no calculation items" above it in the file. A new description is needed for "Visible objects with no description".

thedaxshepherd commented 4 weeks ago

I tested the rule "Visible objects with no description," and the description field looks great.

Is there a plan to add a description to the rule "Calculation groups with no calculation items"?

m-kovalsky commented 3 weeks ago

This has been completed and will be available in the next release.

From: Jason Romans @.> Sent: Wednesday, October 23, 2024 5:19:24 PM To: microsoft/semantic-link-labs @.> Cc: Michael Kovalsky @.>; Assign @.> Subject: Re: [microsoft/semantic-link-labs] Incorrect Description in BPA Rules for rule "Visible objects with no description" (Issue #225)

I tested the rule "Visible objects with no description," and the description field looks great.

Is there a plan to add a description to the rule "Calculation groups with no calculation items"?

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/semantic-link-labs/issues/225#issuecomment-2432596131, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHBQBNVDJDZKEGMIK23ZAXDZ4647ZAVCNFSM6AAAAABQNNUY4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSGU4TMMJTGE. You are receiving this because you were assigned.Message ID: @.***>

thedaxshepherd commented 3 weeks ago

Is the change to add a description rule "Calculation groups with no calculation items" in the current code, or does it still need to be merged? I only ask because I do not see the change in the current code base for the "Calculation Group" description. I built the Wheel file and tested the change to the "Visible Objects" rule. I was going to test the "Calculation Group" rule but did not see the code change.

m-kovalsky commented 3 weeks ago

Fixed in 0.8.4.