microsoft / sqldev

Source code for SQL Server and Azure SQL DB developer getting started tutorials: https://www.microsoft.com/en-us/sql-server/developer-get-started/
91 stars 53 forks source link

contributor-guide folder is missing #7

Closed badersur closed 7 years ago

badersur commented 7 years ago

The following 2 links in the README can't be found:

https://github.com/Microsoft/sqldev/blob/master/contributor-guide/media/documents/markdown-cheatsheet.pdf?raw=true

https://github.com/Microsoft/sqldev/blob/master/contributor-guide/article-metadata.md

ajlam commented 7 years ago

@badersur - I've created PR #10 to fix this. Can you please take a look?

badersur commented 7 years ago

Sorry for late reply. These links are fine now but I've found other links to be broken:

https://github.com/Microsoft/sqldev/blob/master/contributor-guide/tools-and-setup.md

https://github.com/Microsoft/sqldev/blob/master/contributor-guide/git-commands-for-master.md

ajlam commented 7 years ago

@badersur, can you please check out PR #12? This should address the 2 other broken links you found.

badersur commented 7 years ago

@ajlam It looks great :+1:

ajlam commented 7 years ago

Awesome. Merging PR #12 now :)

ajlam commented 7 years ago

Is it alright to close this issue as well?

badersur commented 7 years ago

yep :+1: thanks for asking & fixing it quickly :)

ajlam commented 7 years ago

Appreciate you helping to improve these tutorials as well 😄