search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Leaking notifications make VS Code freeze #62970

Closed gregvanl closed 5 years ago

gregvanl commented 5 years ago

Several hangs in a row. Attached are the log files from two of the hangs which contain the error [error] [VS Code]: detected unresponsive.

InsidersHangs.zip

fusengine commented 5 years ago

why hide my comment 😹

guillaumevincent commented 5 years ago

Freeze on fedora 29 also Vscode:

1.29.0
5f24c93878bd4bc645a4a17c620e2487b11005f9
x64

My extensions:

esbenp.prettier-vscode
ms-python.python
robertohuertasm.vscode-icons

I'm going to test insider version

mateuszgazdziak commented 5 years ago

How to revert to previous version?

fusengine commented 5 years ago

How to revert to previous version?

@mateuszgazdziak do you have a lot process rg?

lorenz068 commented 5 years ago

Same here on Mac OSX Mojave, since the 1.29.0 update

JCMais commented 5 years ago

Was having same issue, latest insiders seems to have fixed it, thanks for working on that.

bsendras commented 5 years ago

VSCode v1.29.0. hangs on Mac OSX High Sierra 10.13.6.

jrieken commented 5 years ago

@bsendras Yeah, we already know that. We work full steam towards 1.29.1. In the meantime you can use insiders: http://code.visualstudio.com/insiders/ which already has the fix for this.

mateuszgazdziak commented 5 years ago

@fusengine I work on Windows 10 :(

YevhenKysilov commented 5 years ago

63214 I have problem with hangs too

YusifKhalilov commented 5 years ago

Same problem. This problem was in the insider version too. Why they released the stable version with this issue?

jrieken commented 5 years ago

This problem was in the insider version too. Why they released the stable version with this issue?

That likely means that you don't have this issue but another issue. That's unhappy but we are here to help and fix. Please file a new issue, bonus points for providing version string, os, etc. Last, please following our perf guide: https://github.com/Microsoft/vscode/wiki/Performance-Issues

fusengine commented 5 years ago

When you fix that ?

wannemuellerit commented 5 years ago

Still having the same issues after your very recent fix. Especially problematic when scrolling or getting new input in the integrated terminal. Also, switching from 'files' to 'search' causes a good lag(and about 25% cpu usage for a few secs)

jrieken commented 5 years ago

@oppoi1 This is about a memory leak that happens with uncleared notification. Your comment doesn't match that, so please file a new issue. Bonus points for following our guidelines: https://github.com/Microsoft/vscode/wiki/Performance-Issues

potomek commented 5 years ago

Today this was happend when I pasted into JavaScript doc. sentence with spaces. I suppose the code validation system froze.

jrieken commented 5 years ago

This issue is about a very specific, fast growing, memory leak that happens when having notifications. We have released a fix for this issue in 1.29.1 and 1.30-insiders. Please make sure to be one of those or later versions.

Different issues often show the same symptoms but the reverse if often not true. That means if you see a slowdown (symptom) it's very likely not this issue but another issue. Please try latest, please file new issues when an issue is closed, please follow this guide: https://github.com/Microsoft/vscode/wiki/Performance-Issues