Can't rearrange tabs anymore

[cheshirekow]

Issue Type: Bug

Sounds exactly like #45303 but that was closed without a resolution other than "windows update made it go away". I use vscode on three different machines running ubuntu 18.04 and I only observe this on one of them. This started happening several updates ago, I wish I had captured the version when it first started. Mostly I've just been living with it for quite a while.

When I try to move a tab from one pane to another, the tab rendering follows my mouse but the tab doesn't move:

And the same happens when I try to move files:

Here's some additional info from the about box:

I am happy to provide additional information and try other debugging steps. And here's the data from the vscode bug report template:

VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:33:40.634Z) OS version: Linux x64 4.15.0-66-generic

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 4299)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|1, 1, 1| |Memory (System)|31.35GB (22.90GB free)| |Process Argv|.| |Screen Reader|no| |VM|0%|

Extensions (9)

Extension|Author (truncated)|Version ---|---|--- cmake-format|che|0.6.0 latex-workshop|Jam|8.2.0 vscode-phpfmt|kok|1.0.30 restructuredtext|lex|114.0.0 python|ms-|2019.10.44104 cpptools|ms-|0.26.1 vsliveshare|ms-|1.0.1056 rewrap|stk|1.9.1 cmake|twx|0.0.17

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[cheshirekow]

Tried again with the insider build, same issue:

[bpasero]

Are you running as admin?

[cheshirekow]

Since this is a linux system, do you mean as root? No, I'm running as a regular user.

[bpasero]

@cheshirekow would you be willing to follow https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_40.md#run-vs-code-web-out-of-sources so that we can see if you can reproduce in your normal browser?

[cheshirekow]

Sure. I cloned the repo and tried yarn web but it fails with :

josh@cobbler:~/Codes/vscode$ yarn web
yarn run v1.19.1
$ node scripts/code-web.js
module.js:550
    throw err;
    ^

Error: Cannot find module 'opn'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)

I don't know what yarn is or if I'm supposed to "build" something in my clone before running it so I'll try to track down why this is failing and report back.

[cheshirekow]

Ok, it appears I had to upgrade nodejs from version 8 to version 10. Then I had to install the yarn package repository and yarn itself. Then I had to build with yarn before yarn web. Anyway, I don't think it works. I get a blank page and the following is printed to the console:

josh@cobbler:~/Codes/vscode$ yarn web
yarn run v1.19.1
$ node scripts/code-web.js
Web UI available at http://localhost:8080
Error: ENOENT: no such file or directory, stat '/home/josh/Codes/vscode/out/vs/loader.js'

[cheshirekow]

Hm.. there is this note:

Tip! If you receive an error stating that the app is not a valid Electron app, it probably means you didn't run yarn watch first.

So I tried that. I ran yarn watch in one terminal and yarn web in another. I get a new error. In the watch terminal I get:

[06:50:52] Error: /home/josh/Codes/vscode/src/vs/platform/windows/electron-main/windowsMainService.ts(201,86): Cannot find module 'windows-mutex'.
[06:50:52] Error: /home/josh/Codes/vscode/src/vs/platform/update/electron-main/updateService.win32.ts(232,30): Cannot find module 'windows-mutex'.
[06:50:52] Error: /home/josh/Codes/vscode/src/vs/code/test/electron-main/nativeHelpers.test.ts(15,30): Cannot find module 'windows-mutex'.
[06:50:52] Finished compilation with 3 errors after 61655 ms

and in the web terminal I get:

josh@cobbler:~/Codes/vscode$ yarn web
yarn run v1.19.1
$ node scripts/code-web.js
Web UI available at http://localhost:8080
Error: ENOENT: no such file or directory, stat '/home/josh/Codes/vscode/out/vs/code/browser/workbench/workbench.js'

[cheshirekow]

Ok so I checked and that file actually does exist... So I tried yarn web again and this time it worked. In the chrome window, the problem is not observed. However, when I start vscode again, also the problem is not observed (i.e. it went away). Is it possible that the problem was due to a system node version 8 instead of 10? I think that is the only system wide thing that changed during this process.

[bpasero]

@cheshirekow strange, did you maybe meanwhile update VSCode to a newer version? Is it resolved for good?

[cheshirekow]

It doesn't look like it updated. The about box still shows the same info (version 1.39.2, same commit, same date, same Node.js version).

Is it resolved for good?

Too early to tell. I'll report back after a few restarts.

[bpasero]

Ok thanks, but if it is random as you say I don't think VSCode can fix anything.

[cheshirekow]

No, the problem is back again after a reboot. I don't really think it's random, it's pretty consistent. I tried all three of vcode, vscode-insiders and the web version and the problem is present in all three versions.

BTW, the build system for the web version seems really flakey. I have to try multiple invocations of yarn and or yarn web before it works.

[bpasero]

@cheshirekow so you can reproduce this in the web version in a recent browser (which one)? then I think you might want to report this against the browser directly?

[cheshirekow]

@bpasero I can reproduce this in the web version in google chrome 78.0.3904.70

But the problem is not present in firefox 70.0.1

then I think you might want to report this against the browser directly?

Sorry, why should I report to chrome that tab's don't work in vscode? Are the two related in some way that I'm not aware of?

[bpasero]

@cheshirekow

Sorry, why should I report to chrome that tab's don't work in vscode? Are the two related in some way that I'm not aware of?

Well, VSCode is written using HTML + JS + CSS and as you can see in Firefox we seem to be doing the right thing (and for all of our other users in Chrome as it seems). So arguably something is going on in your system that other users are not impacted. Would you agree that VSCode is unlikely to be able to address this given that analysis? Going forward filing this against Chrome would give us a chance that we hear back from developers as to why this is not working.

As a next step, can you open https://vscode-web-test-playground.azurewebsites.net/ and see if you can reproduce it there? This is a version of VSCode that is much similar to "yarn web" but runs online so that we can give this to chrome developers. Thanks!

[cheshirekow]

as you can see in Firefox we seem to be doing the right thing

Eh... I wouldn't really go that far. Maybe firefox is doing something non-standard and something somewhere is depending on that behavior. But anyway...

Would you agree that VSCode is unlikely to be able to address this given that analysis?

Possibly. Just because I'm the only one reporting it doesn't mean I'm the only one experiencing it... but I guess the squeaky wheel and all that. I'm happy to dig in further. For example, any idea where the tab management logic resides in code? Maybe I can add some debug prints and figure out whether the "drop" (in the drag-and-drop sense) event is recorded or not.

Going forward filing this against Chrome

I still don't understand what chrome has to do with this. I guess it also doesn't work in chrome, but I don't really care about the web version and I don't normally run it in chrome. I would be happy to open a ticket, but I don't have confidence in my ability provide any useful information to them: "This software that isn't your software doesn't work and the developer told me to talk to you because another version of their software (not the one that I'm using) also doesn't work in the same way when it runs inside your software." I can't imagine that going very far.

As a next step, can you open https://vscode-web-test-playground.azurewebsites.net/ and see if you can reproduce it there?

Yup, issue is present with chrome at that site. Issue is not present with firefox at that site.

[cheshirekow]

One additional piece of data. On a machine where I do not experience this issue, the empty space next to the tabs becomes lighter when I drag a tab over it. See also the GIF of firefox above, you can see this effect. On the machine where I experience this issue, the empty space does not become lighter. Seems to suggest that "is-hovering-over-this-hot-zone" is not detected for some reason.

[bpasero]

@cheshirekow

I still don't understand what chrome has to do with this.

Oh, Chrome is the engine that we use in VSCode for rendering everything (due to our use of Electron). So it is likely that if something does not work in VSCode is might also not work in Chrome.

Yeah, if you want to debug this:

• running out of sources setup: https://github.com/microsoft/vscode/wiki/How-to-Contribute
• drag and drop code is in tabsTitleControl#648

[cheshirekow]

Oh, Chrome is the engine that we use in VSCode Ah, ok so now that makes sense.

So I added some console.log() to tabsTitleControl.ts and I compared against a machine where I don't observe this issue. Interestingly:

with issue:

[5998:1112/000625.167768:INFO:CONSOLE(444)] "Drag start", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (444)
[5998:1112/000628.358882:INFO:CONSOLE(507)] "Drag end", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (507)
[6075:1112/000628.695606:WARNING:x11_util.cc(1430)] X error received: serial 2933, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown)
[5998:1112/000629.815769:INFO:CONSOLE(444)] "Drag start", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (444)
[5998:1112/000632.478996:INFO:CONSOLE(507)] "Drag end", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (507)
[6075:1112/000632.829323:WARNING:x11_util.cc(1430)] X error received: serial 2987, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown)
[5998:1112/000634.803590:INFO:CONSOLE(444)] "Drag start", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (444)
[5998:1112/000635.774773:INFO:CONSOLE(507)] "Drag end", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (507)
[6075:1112/000635.796198:WARNING:x11_util.cc(1430)] X error received: serial 3032, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown)

without issue:

[25067:1112/000730.033403:INFO:CONSOLE(444)] "Drag start", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (444)
[25067:1112/000730.066492:INFO:CONSOLE(465)] "Drag enter", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (465)
[25067:1112/000730.066603:INFO:CONSOLE(480)] "This is a local drag and drop", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (480)
[25067:1112/000730.076852:INFO:CONSOLE(465)] "Drag enter", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (465)
[25067:1112/000730.076916:INFO:CONSOLE(480)] "This is a local drag and drop", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (480)
[25067:1112/000730.077201:INFO:CONSOLE(502)] "Drag leave", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (502)
[25144:1112/000730.080143:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
[25067:1112/000730.090357:INFO:CONSOLE(465)] "Drag enter", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (465)
[25067:1112/000730.090391:INFO:CONSOLE(480)] "This is a local drag and drop", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (480)
[25067:1112/000730.108159:INFO:CONSOLE(465)] "Drag enter", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (465)
[25067:1112/000730.108193:INFO:CONSOLE(480)] "This is a local drag and drop", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (480)
[25067:1112/000730.108727:INFO:CONSOLE(502)] "Drag leave", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (502)
[25067:1112/000730.116402:INFO:CONSOLE(465)] "Drag enter", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (465)
[25067:1112/000730.116491:INFO:CONSOLE(480)] "This is a local drag and drop", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (480)
[25067:1112/000730.218323:INFO:CONSOLE(502)] "Drag leave", source: file:///home/josh/Codes/vscode/out/vs/workbench/browser/parts/editor/tabsTitleControl.js (502)

Some noteable things:

1. On the machine experiencing the issue, there appears to be some window management cruft. request_code 4 is X_DestroyWindow so it appears the window has already been destroyed? I'm not sure where x11_util.cc is in order to investigate what it's doing.
2. On the machine experiencing the issue the intermediate "Drag enter" and "Drag leave" events aren't firing whereas on the machine without the issue they do fire.
3. On the machine without the issue, there is some GL ERROR cruft. I suspect it is unrelated.

[bpasero]

@cheshirekow nice findings. Does it reproduce with our previous stable release: https://az764295.vo.msecnd.net/stable/6ab598523be7a800d7f3eb4d92d7ab9a66069390/code-stable-1571154019.tar.gz

?

[vscodebot[bot]]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[vscodebot[bot]]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[bpasero]

@cheshirekow Does it reproduce with our previous stable release: https://az764295.vo.msecnd.net/stable/6ab598523be7a800d7f3eb4d92d7ab9a66069390/code-stable-1571154019.tar.gz

?

[cheshirekow]

@bpasero yes, it reproduces with that version, but appears to be the same version as when I originally posted:

[defrex]

FWIW, this happens to me as well. I'm also on Linux. In my experience, it's intermittent and happens mid-coding-session regularly.

[cheshirekow]

FYI, I did file a bug through the chrome help menu, but I'm pretty sure no human will ever read it. I found http://dev.chromium.org/for-testers/bug-reporting-guidelines so I will probably try to file a bug there as well... once I figure out the correct way to do it.

[defrex]

IMO, it's a little silly to call this a chrome bug. Distributing via Electron means you need to support chrome, warts and all. :woman_shrugging:

[SEAPUNK]

Happens to me too. I'm running on a multi monitor setup, I'm curious if that could be causing the problem (wild guess after seeing the X error message in the logs above). I'll try to repro this issue without attaching the second monitor.

[deepak1556]

I'll try to repro this issue without attaching the second monitor.

@SEAPUNK that would be good info if you can verify.

I tried to repo on my Ubuntu 18.04 parallels vm and couldn't get this issue, so definitely a specific setup triggers this issue.

@cheshirekow if you have repo steps on chrome then you can file a bug using https://bugs.chromium.org/p/chromium/issues/list

[gusbemacbe]

@bpasero and @deepak1556, I have still this problem with the tabs moving and with the files moving in the sidebar. I use the latest version of VSCode Insiders (I used .tar.gz) on Arch Linux.

$ code-insiders --version
1.53.0-insider
4a875e23d20b64504a818834f3fa4c40adb8d480
x64

$ code-insiders --status 
(electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
[20223:1227/010534.589460:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.
Version:          Code - Insiders 1.53.0-insider (4a875e23d20b64504a818834f3fa4c40adb8d480, 2020-12-21T12:39:40.504Z)
OS Version:       Linux x64 5.4.85-1-lts
CPUs:             AMD Ryzen 7 2700X Eight-Core Processor (16 x 2162)
Memory (System):  15.59GB (4.44GB free)
Load (avg):       1, 1, 1
VM:               0%
Screen Reader:    no
Process Argv:     --no-sandbox --crash-reporter-id 550eedd4-affa-4b2c-9fe0-c4ffe8fddfa9
GPU Status:       2d_canvas:                  enabled
                  gpu_compositing:            enabled
                  multiple_raster_threads:    enabled_on
                  oop_rasterization:          disabled_off
                  opengl:                     enabled_on
                  protected_video_decode:     unavailable_off
                  rasterization:              disabled_software
                  skia_renderer:              enabled_on
                  video_decode:               disabled_software
                  vulkan:                     disabled_off
                  webgl:                      enabled
                  webgl2:                     enabled

CPU %   Mem MB     PID  Process
    0      144   16450  code-insiders main
    0       32   16452     zygote
    0      128   16480       gpu-process
    0       32   16453     zygote
    0       64   16507     utility
    0      208   16526     window (● .instagram #instafeed • Untitled-1 - PHP Avançado (Workspace) - Visual Studio Code - Insiders [Unsupported])
    0        0   16606       /bin/zsh
    0      351   16608       extensionHost
    0       64   17772         /home/gusbemacbe/Aplicativos/Sources/VSCode Insiders/code-insiders /home/gusbemacbe/Aplicativos/Sources/VSCode Insiders/resources/app/extensions/css-language-features/server/dist/node/cssServerMain --node-ipc --clientProcessId=16608
    0       48   17773         electron_node serverMain.js 
    0       48   17780         electron_node server.js 
    0      208   17827         PHP Language Server
    0       48   18878         /home/gusbemacbe/Aplicativos/Sources/VSCode Insiders/code-insiders /home/gusbemacbe/Aplicativos/Sources/VSCode Insiders/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=16608
    0       80   16829       watcherService
    0       64   16897       searchService
    0        0   17877       /bin/zsh
    0        0   20176         sh /home/gusbemacbe/.local/bin/code-insiders --status
    0       48   20181           electron_node cli.js 
    0       96   20193             /home/gusbemacbe/Aplicativos/Sources/VSCode Insiders/code-insiders --status --no-sandbox
    0       32   20195               zygote
    0       96   20223                 gpu-process
    0       32   20196               zygote
    0        0   20259               utility
    0      128   17723     shared-process
    0        0   20250       /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=

Workspace Stats: 
|  Window (● .instagram #instafeed • Untitled-1 - PHP Avançado (Workspace) - Visual Studio Code - Insiders [Unsupported])
|    Folder (lerma-moveis-finos): 1982 files
|      File types: php(905) rst(114) json(54) rb(53) md(36) js(34) 2(28) 0(26)
|                  css(24) 1(20)
|      Conf files: package.json(3) makefile(3) settings.json(1) gulp.js(1)

[abmantis]

I'm also having this issue on my two machines. One is running up to date Arch, and the other running Ubuntu 20.10, both using Wayland (sway) and not X11.

On my Arch machine:

Version: 1.53.2
Commit: 622cb03f7e070a9670c94bae1a45d78d7181fbd4
Date: 2021-02-11T11:48:44.518Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.10.15-arch1-1

[deepak1556]

@abmantis @gusbemacbe Do you have the issue when you run with --disable-gpu ?

[abmantis]

@abmantis @gusbemacbe Do you have the issue when you run with --disable-gpu ?

Yep, still can't drag tabs or files.

[jwittbrodt]

I have the same issue, also on up-to-date Arch using sway. No change between the latest stable (visual-studio-code-bin package) and the insiders build (visual-studio-code-insiders-bin). It does not only affect tabs, but also moving files by dragging them in tree view.

I also tried the --disable-gpu suggestion and it did not change anything.

[gusbemacbe]

@abmantis @gusbemacbe Do you have the issue when you run with --disable-gpu ?

On Arch and Manjaro with i3 and Sway, yes, still.

[mozartilize]

hi, any update on this? just encounter the bug today on sway (wayland) - Ubuntu 20.04

[deepak1556]

Please check if the issue happens with latest insiders that has updated runtime https://code.visualstudio.com/insiders, for wayland users start the app with code-insiders --enable-features=UseOzonePlatform --ozone-platform=wayland

[gusbemacbe]

Please check if the issue happens with latest insiders that has updated runtime https://code.visualstudio.com/insiders, for wayland users start the app with code-insiders --enable-features=UseOzonePlatform --ozone-platform=wayland

It worked, I could rearrange tabs and files in the explorer. But the font lost the antialiasing:

[deepak1556]

@gusbemacbe Can you also start with --force-device-scale-factor=1

[gusbemacbe]

@gusbemacbe Can you also start with --force-device-scale-factor=1

It is not antialiasing yet:

[koxu1996]

I am facing the same issue on Arch Linux with Sway. AFAIR it stopped working ~1 month ago.

[Rahulkhinchi03]

is it something in my laptop setting? How can I resolve this?

On Wed, May 12, 2021 at 4:56 PM koxu1996 @.***> wrote:

I am facing the same issue on Arch Linux with Sway. AFAIR it stopped working ~1 month ago.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/83568#issuecomment-839694197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDDKWV5HBEUWWO2BSURHKLTNJQX7ANCNFSM4JGNOCNA .

[pangteypiyush]

It seems vscode window loses focus while dragging tab (?). For example: trying to move markdown preview tab when a terminal window is present just behind the vscode window, terminal will receive something (as if copy & pasted) like

webview-panel:webview-panel/webview-a3397465-3e8e-45af-81c9-8904efd6c9c1

[techandsoftware]

Same issue. Running in Debian in ChromeOS

Version: 1.57.1 Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48 Date: 2021-06-17T13:26:56.255Z Electron: 12.0.7 Chrome: 89.0.4389.128 Node.js: 14.16.0 V8: 8.9.255.25-electron.0 OS: Linux x64 5.4.109-26091-g577602338376

[mozartilize]

Please check if the issue happens with latest insiders that has updated runtime https://code.visualstudio.com/insiders, for wayland users start the app with code-insiders --enable-features=UseOzonePlatform --ozone-platform=wayland

why you suggest run on native wayland? will the bug remain in xwayland and wont fix?

[gusbemacbe]

@koxu1996 and @mozartilize

Try the small tutorial: @tinywrkbd's https://github.com/flatpak/flatpak/issues/2861#issuecomment-742421920

With this systemd, rearranging the tabs worked for me.

I am using @ahgood's extension MoveTab to rearrange the tabs with keybindings.

[koxu1996]

@gusbemacbe In my case xdg-desktop-portal.service is not enabled. I started it with env XDG_CURRENT_DESKTOP=sway but rearranging tabs still does not work.

[gusbemacbe]

@gusbemacbe In my case xdg-desktop-portal.service is not enabled. I started it with env XDG_CURRENT_DESKTOP=sway but rearranging tabs still does not work.

Have you xdg-desktop-portal installed?

[koxu1996]

@gusbemacbe Yes, I have xdg-desktop-portal installed, but it does not matter now... suddenly rearranging tabs is working for me :laughing: