Closed micuintus closed 6 years ago
FYI: I did some experiments with QtQuick.Layouts
. Using them radically simplifies the code. Unfortunately, I couldn't get them running properly on Sailfish --- even if don't use margins with layouts. It seems, we have to park the branch (micu/fixtruncation#215_layouts) until Jolla decides to finally update Sailfish to a proper Qt version, which will happen with Sailfish 3, sometime later this year...
I thought about several options for the right way of expressing 'the venue is closed now, but open in a few minutes/hours/days' (as opposed to: 'it is cloased for a longer/undetermined period or forever') --- in German and in English. I came up with several terms: "gerade geschlossen", "currently closed", "momentan geschlossen", "closed at the moment", "derzeit geschlossen", ...
I came to the conclusion that probably the best terms are either just "geschlossen"/"closed" or "jetzt geschlossen"/"closed now". Should we go for "jetzt geschlossen"/"closed now"?
We can do that, but what about the multiline issue: "jetzt geschlossen" won't fit in one line on all devices.
Overall it is working pretty well! However, there is some points I don't like about the PR. Changing the text from
closed at the moment
toclosed now
has disadvantages:derzeit geschlossen
is pretty long though and it would be better to have that in two lines. Also there we be something likecloses by\n%1$s clock!
from the Android app, which also should be two lines.I would suggest to revert that part of the patch and find a better way to calculation the actual width of the text, e.g. with
TextMetrics
: http://doc.qt.io/qt-5/qml-qtquick-textmetrics.html