search

micuintus / harbour-Berlin-Vegan

Berlin-Vegan Guide
Other
14 stars 4 forks source link

Mark closed venues in map overview #255

Closed jmastr closed 5 years ago

jmastr commented 5 years ago

Closes #231

micuintus commented 5 years ago

Very cool, thanks!

I'd be fine with merging it. But with #257 in place, I think we should at least re-discuss whether it still makes sense to have the closed venues grayed out.

Situation: With this patch, you get one information (closed / open state), but you loose another one (vegan category) in the case the venue is closed.

For both information can be filtered now, so its a matter of priorities. I don't have a very strong opinion here, but my gut feeling is to rather not gray out the closed venues in the map. What do you think, @jmastr , @smeir ?

jmastr commented 5 years ago

Closed in favour of #257