search

micuintus / harbour-Berlin-Vegan

Berlin-Vegan Guide
Other
14 stars 4 forks source link

Micu/mark currently applicable line in the opening hours in venue description #289 #309

Closed micuintus closed 4 years ago

jmastr commented 4 years ago

309_2

@micuintus Don't know, if it is part of your patch, but shouldn't be the opening hours here in one line?

micuintus commented 4 years ago

@jmastr Good catch!

Don't know, if it is part of your patch,

No, this was already part of #237

but shouldn't be the opening hours here in one line?

The problem is: If it is a holiday people might get confused why not the current day was chosen. Therfore we renamed Subday to Sunday / Holdiday, but now the collapsing looks akward for that, which is why we removed it.

https://github.com/micuintus/harbour-Berlin-Vegan/commit/5fd074c6b8e1ff0ae09bcdb5efaeb9eda0a27343

jmastr commented 4 years ago

The problem is: If it is a holiday people might get confused why not the current day was chosen. Therfore we renamed Subday to Sunday / Holdiday, but now the collapsing looks akward for that, which is why we removed it.

We can leave it for now, but this solution isn't ideal either...

micuintus commented 4 years ago

The problem is: If it is a holiday people might get confused why not the current day was chosen. Therfore we renamed Sunday to Sunday / Holiday, but now the collapsing looks akward for that, which is why we removed it.

We can leave it for now, but this solution isn't ideal either...

Agreed, its not. But: It was not introduced within the scope of this ticket :D On the other hand, one could argue that marking the open line mitigates the issue why we renamed Sunday to Sunday / Holiday, a bit. But I'd say lets leave this for another ticket.

jmastr commented 4 years ago

Let's tackle that in a follow-up ticket, since the PR did not introduce the warning and the PRs is big enough already.