search

migtools / mig-controller

OpenShift Migration Controller
Apache License 2.0
22 stars 41 forks source link

oc sa get-token is deprecated #1363

Closed awels closed 8 months ago

awels commented 8 months ago

oc sa get-token is deprecated and no longer works on openshift 4.14 and newer, replace with current oc create token command

jmontleon commented 8 months ago

Thank you for the PR. Do you know what the default duration oc a token is when running oc create token is? I believe it's 1h, but I am far from certain. In either case is 1h sufficient for what this script is doing or should we extend the life with --duration flag?

awels commented 8 months ago

Yeah I am pretty sure it is an hour, and this probably not long enough. I have run into the token timing out while I was testing stuff. Let me increase the timeout to 24 hours or something like that.