migtools / mig-controller

OpenShift Migration Controller
Apache License 2.0
22 stars 42 forks source link

Instead of -new add -mig-xxxx to the end of the new pv names #1393

Closed awels closed 1 month ago

awels commented 1 month ago

In order to support multiple migrations of the same PV we need to add a unique suffix to the end of the PV name when creating new PVs. The new suffix is '-mig-' + 4 character random string of letters. When migrating a PV that already has the suffix, we will remove the suffix and create a new one.

In order to support legacy plans and pvs if the suffix is -new we replace -new with -mig-xxxx for the new pv name.

relaxed the validation of pvs to only include pvs that are not being skipped in the plan. This allows for the original pv to still exist in the namespace.

Goes with https://github.com/migtools/mig-ui/pull/1525 which modifies the UI to properly allow users to select the PVs and get feedback if their selection is valid or not.

awels commented 1 month ago

/cc @dymurray If you could review?