Rust version: slight improvements to naive implementation

mikepound / opencubes

A community improved version of the polycubes project!

MIT License

44 stars 23 forks source link

Rust version: slight improvements to naive implementation #21

Closed datdenkikniet closed 1 year ago

datdenkikniet commented 1 year ago

Rename some things so that it's more obvious what they are
Make RawPCube a type so we can easily convert between items coming from/going to a .pcube file and "others"
Split out file handling a bit

datdenkikniet commented 1 year ago

Fun fact: calculating rotations on the NaivePolyCube is so slow that a845b9d sped up enumeration by ~40%

datdenkikniet commented 1 year ago

I have rebased my changes on current main now, now it's small peanuts :) Would appreciate a review (@NailLegProcessorDivide) and a merge @bertie2, if/when able!

NailLegProcessorDivide commented 1 year ago

+2 looks all good to me.