search

mikeseven / node-glfw

nodejs bindings to GLFW
103 stars 46 forks source link

Issue in the test_atb.js #25

Closed AndreyArsov closed 8 years ago

AndreyArsov commented 8 years ago

There is a bug in the javascript, creating new bar should be done with

twBar=ATB.NewBar("Cube");

instead of using a constructor

twBar=new ATB.NewBar("Cube");

mikeseven commented 8 years ago

Thanks good catch.

--mike

On Sat, Mar 12, 2016 at 7:11 PM -0800, "AndreyArsov" notifications@github.com<mailto:notifications@github.com> wrote:

There is a bug in the javascript, creating new bar should be done with

twBar=ATB.NewBar("Cube");

instead of using a constructor

twBar=new ATB.NewBar("Cube");

Reply to this email directly or view it on GitHubhttps://github.com/mikeseven/node-glfw/issues/25.

AndreyArsov commented 8 years ago

Btw great library. Very easy for showing client usage in node.

Thanks for putting the effort

Andrey.

Andrey (phone)

-----Original Message----- From: "m1k3" notifications@github.com Sent: ‎3/‎16/‎2016 4:39 PM To: "mikeseven/node-glfw" node-glfw@noreply.github.com Cc: "AndreyArsov" andrey_arsov@yahoo.com Subject: Re: [node-glfw] Issue in the test_atb.js (#25)

Thanks good catch.

--mike

On Sat, Mar 12, 2016 at 7:11 PM -0800, "AndreyArsov" notifications@github.com<mailto:notifications@github.com> wrote:

There is a bug in the javascript, creating new bar should be done with

twBar=ATB.NewBar("Cube");

instead of using a constructor

twBar=new ATB.NewBar("Cube");

Reply to this email directly or view it on GitHubhttps://github.com/mikeseven/node-glfw/issues/25.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

mikeseven commented 8 years ago

fixed, thanks!