search

mikeseven / node-glfw

nodejs bindings to GLFW
103 stars 46 forks source link

../src/atb.cc:294:57: error: ‘class v8::Isolate’ has no member named ‘GetCurrentContext’ #26

Closed misaka-10032 closed 6 years ago

misaka-10032 commented 6 years ago

npm install node-glfw fails.

https://github.com/mikeseven/node-glfw/blob/dbec0b66116e7ead6fd4f271f19369f7eca3f7a3/src/atb.cc#L265

v8 API seems to be updated. My npm version is 1.3.10.

mikeseven commented 6 years ago

Thanks I'll have a look asap.

-- mike

From: Rocky Cai notifications@github.com Sent: Sunday, January 7, 2018 4:46:01 PM To: mikeseven/node-glfw Cc: Subscribed Subject: [mikeseven/node-glfw] ../src/atb.cc:294:57: error: ‘class v8::Isolate’ has no member named ‘GetCurrentContext’ (#26)

npm install node-glfw fails.

https://github.com/mikeseven/node-glfw/blob/dbec0b66116e7ead6fd4f271f19369f7eca3f7a3/src/atb.cc#L265

v8 API seems to be updated. My npm version is 1.3.10.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/mikeseven/node-glfw/issues/26, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAxYLAlWzWx3RWcl5kfEPEpht7dHcSytks5tIWVJgaJpZM4RV2or.

misaka-10032 commented 6 years ago

Well, I guess it's not because of API update, but because I was using an outdated node. My node version is v0.10.25, and I go check the v8 doc for that version, the function was not there. However, for a newer version of node, it should be there

I'll try to update my node. Sorry about bugging you.