search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

enhance: Delete all metrics after the nodes stop (#32503) #32692

Closed bigsheeper closed 3 weeks ago

bigsheeper commented 3 weeks ago
  1. Delete all metrics after the nodes stop
  2. Delete limiter rate metrics when collection dropped

issue: https://github.com/milvus-io/milvus/issues/32063, https://github.com/milvus-io/milvus/issues/32062

pr: https://github.com/milvus-io/milvus/pull/32503

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus/blob/2.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 3 weeks ago

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 3 weeks ago

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.64%. Comparing base (51e0855) to head (303eaf1). Report is 4 commits behind head on 2.4.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32692/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #32692 +/- ## ========================================== + Coverage 81.58% 81.64% +0.06% ========================================== Files 976 976 Lines 120147 120419 +272 ========================================== + Hits 98019 98317 +298 + Misses 18396 18378 -18 + Partials 3732 3724 -8 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/distributed/datacoord/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Fdatacoord%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvZGF0YWNvb3JkL3NlcnZpY2UuZ28=) | `88.88% <100.00%> (+0.04%)` | :arrow_up: | | [internal/distributed/datanode/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Fdatanode%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvZGF0YW5vZGUvc2VydmljZS5nbw==) | `83.00% <100.00%> (+0.08%)` | :arrow_up: | | [internal/distributed/indexnode/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Findexnode%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvaW5kZXhub2RlL3NlcnZpY2UuZ28=) | `74.14% <100.00%> (+0.17%)` | :arrow_up: | | [internal/distributed/proxy/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Fproxy%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcHJveHkvc2VydmljZS5nbw==) | `83.89% <100.00%> (+0.02%)` | :arrow_up: | | [internal/distributed/querycoord/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Fquerycoord%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcXVlcnljb29yZC9zZXJ2aWNlLmdv) | `77.82% <100.00%> (+0.09%)` | :arrow_up: | | [internal/distributed/querynode/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Fquerynode%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcXVlcnlub2RlL3NlcnZpY2UuZ28=) | `83.42% <100.00%> (+0.09%)` | :arrow_up: | | [internal/distributed/rootcoord/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fdistributed%2Frootcoord%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcm9vdGNvb3JkL3NlcnZpY2UuZ28=) | `82.32% <100.00%> (+0.07%)` | :arrow_up: | | [internal/proxy/impl.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=internal%2Fproxy%2Fimpl.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvaW1wbC5nbw==) | `86.39% <100.00%> (+<0.01%)` | :arrow_up: | | [pkg/metrics/datacoord\_metrics.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=pkg%2Fmetrics%2Fdatacoord_metrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL21ldHJpY3MvZGF0YWNvb3JkX21ldHJpY3MuZ28=) | `100.00% <100.00%> (ø)` | | | [pkg/metrics/datanode\_metrics.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree&filepath=pkg%2Fmetrics%2Fdatanode_metrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL21ldHJpY3MvZGF0YW5vZGVfbWV0cmljcy5nbw==) | `100.00% <100.00%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/milvus-io/milvus/pull/32692?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)