milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

enhance: Upgrade knowhere to 2.3.1 #32699

Closed liliu-z closed 3 weeks ago

liliu-z commented 3 weeks ago

/kind improvement

mergify[bot] commented 3 weeks ago

@liliu-z

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:

    • feat: for introducing a new feature.
    • fix: for bug fixes.
    • enhance: for improvements to existing functionality.
    • test: for add tests to existing functionality.
    • doc: for modifying documentation.
    • auto: for the pull request from bot.
  2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] commented 3 weeks ago

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.76%. Comparing base (29d3c57) to head (a2378bb). Report is 8 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32699/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32699 +/- ## ========================================== - Coverage 81.79% 81.76% -0.03% ========================================== Files 998 998 Lines 124188 124209 +21 ========================================== - Hits 101576 101564 -12 - Misses 18762 18781 +19 - Partials 3850 3864 +14 ``` [see 36 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32699/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
yanliang567 commented 3 weeks ago

/lgtm /approve

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)~~ [yanliang567] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment