search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

fix: Use default integration case timeout for `TestBinlogImport` #32701

Closed congqixia closed 3 weeks ago

congqixia commented 3 weeks ago

See also #32700

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/integration/OWNERS](https://github.com/milvus-io/milvus/blob/master/tests/integration/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 3 weeks ago

/run-cpu-e2e

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 3 weeks ago

/run-cpu-e2e

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 3 weeks ago

/run-cpu-e2e

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.75%. Comparing base (29d3c57) to head (2e16f69). Report is 9 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32701/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32701 +/- ## ========================================== - Coverage 81.79% 81.75% -0.04% ========================================== Files 998 998 Lines 124188 124207 +19 ========================================== - Hits 101576 101549 -27 - Misses 18762 18793 +31 - Partials 3850 3865 +15 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32701?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [tests/integration/minicluster\_v2.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32701?src=pr&el=tree&filepath=tests%2Fintegration%2Fminicluster_v2.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-dGVzdHMvaW50ZWdyYXRpb24vbWluaWNsdXN0ZXJfdjIuZ28=) | `72.51% <ø> (+0.54%)` | :arrow_up: | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32701/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
tedxu commented 3 weeks ago

/lgtm