Open bigsheeper opened 3 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@bigsheeper ut workflow job failed, comment rerun ut
can trigger the job again.
Attention: Patch coverage is 85.96491%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 81.74%. Comparing base (
83ce352
) to head (ecf5b75
). Report is 12 commits behind head on master.
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@bigsheeper ut workflow job failed, comment rerun ut
can trigger the job again.
Since SQ thread pool is present in
cgo.Search
, allocating goroutines at the segments level for concurrency is unnecessary. Simply use the thread pool directly at the segments level to avoid extra goroutines.issue: https://github.com/milvus-io/milvus/issues/27456