search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

enhance: Remove deprecated EnableIndex #32704

Closed bigsheeper closed 2 weeks ago

bigsheeper commented 3 weeks ago

/kind improvement

bigsheeper commented 3 weeks ago

rerun ut

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.75%. Comparing base (6289f3a) to head (2f19adf). Report is 37 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32704/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32704 +/- ## ========================================== + Coverage 81.72% 81.75% +0.03% ========================================== Files 998 998 Lines 124209 124208 -1 ========================================== + Hits 101513 101550 +37 + Misses 18822 18791 -31 + Partials 3874 3867 -7 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32704?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querycoordv2/meta/coordinator\_broker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32704?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fmeta%2Fcoordinator_broker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL21ldGEvY29vcmRpbmF0b3JfYnJva2VyLmdv) | `92.12% <100.00%> (ø)` | | | [internal/querynodev2/segments/segment.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32704?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudC5nbw==) | `68.33% <100.00%> (ø)` | | | [internal/querynodev2/segments/segment\_loader.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32704?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment_loader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudF9sb2FkZXIuZ28=) | `72.06% <100.00%> (-0.03%)` | :arrow_down: | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32704/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
czs007 commented 2 weeks ago

/approve /lgtm

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querycoordv2/meta/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querycoordv2/meta/OWNERS)~~ [czs007] - ~~[internal/querynodev2/segments/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/segments/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment