milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

fix: Refine index param check for Create/Alter Index #32712

Closed congqixia closed 2 weeks ago

congqixia commented 3 weeks ago

See also #32711

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/datacoord/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.77%. Comparing base (a43baa0) to head (73329c4). Report is 10 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32712/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32712 +/- ## ======================================= Coverage 81.77% 81.77% ======================================= Files 998 998 Lines 124209 124201 -8 ======================================= - Hits 101566 101561 -5 + Misses 18780 18777 -3 Partials 3863 3863 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32712?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/index\_service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32712?src=pr&el=tree&filepath=internal%2Fdatacoord%2Findex_service.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2luZGV4X3NlcnZpY2UuZ28=) | `94.91% <100.00%> (+0.91%)` | :arrow_up: | | [internal/datacoord/indexnode\_manager.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32712?src=pr&el=tree&filepath=internal%2Fdatacoord%2Findexnode_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2luZGV4bm9kZV9tYW5hZ2VyLmdv) | `90.14% <100.00%> (-0.28%)` | :arrow_down: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32712/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
xiaocai2333 commented 2 weeks ago

/lgtm