enhance: Upgrade bitset for ARM SVE

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications

https://milvus.io

Apache License 2.0

27.29k stars 2.63k forks source link

enhance: Upgrade bitset for ARM SVE #32718

Open alexanderguzhva opened 3 weeks ago

alexanderguzhva commented 3 weeks ago

issue: #32826 improve ARM SVE performance for internal/core/src/bitset

Baseline timings for gcc 11.4 + Graviton 3 + manually enabled SVE: https://gist.github.com/alexanderguzhva/a974b50134c8bb9255fb15f144e5ac83

Candidate timings for gcc 11.4 + Graviton 3 + manually enabled SVE: https://gist.github.com/alexanderguzhva/19fc88f4ad3757e05e0f7feaf563b3d3

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexanderguzhva To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mergify[bot] commented 3 weeks ago

@alexanderguzhva

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:
- feat: for introducing a new feature.
- fix: for bug fixes.
- enhance: for improvements to existing functionality.
- test: for add tests to existing functionality.
- doc: for modifying documentation.
- auto: for the pull request from bot.
Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

mergify[bot] commented 3 weeks ago

@alexanderguzhva Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.14%. Comparing base (efdbd8e) to head (d1f0bd4). Report is 20 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32718/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32718 +/- ## ========================================== + Coverage 82.12% 82.14% +0.02% ========================================== Files 1007 998 -9 Lines 127726 127941 +215 ========================================== + Hits 104894 105102 +208 Misses 18875 18875 - Partials 3957 3964 +7 ``` [see 215 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32718/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

zhagnlu commented 2 weeks ago

/lgtm

mergify[bot] commented 2 weeks ago

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.