search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

fix: gc only do once #32722

Closed chyezh closed 3 weeks ago

chyezh commented 3 weeks ago

issue: #29655

produced by pr: #31740

czs007 commented 3 weeks ago

/approve /lgtm

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/datacoord/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.73%. Comparing base (6289f3a) to head (aa9e55f). Report is 6 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32722/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32722 +/- ## ======================================= Coverage 81.72% 81.73% ======================================= Files 998 998 Lines 124209 124292 +83 ======================================= + Hits 101513 101589 +76 + Misses 18822 18820 -2 - Partials 3874 3883 +9 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32722?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/garbage\_collector.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32722?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fgarbage_collector.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2dhcmJhZ2VfY29sbGVjdG9yLmdv) | `88.80% <100.00%> (ø)` | | ... and [37 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32722/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)