search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

enhance: Remove legacy L0 segment if watch failed #32725

Closed congqixia closed 2 weeks ago

congqixia commented 3 weeks ago

Like growing segments, legacy l0 segments shall be removed if watch dml channel execution fails as well.

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (b6c06ff) to head (85cde11). Report is 15 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32725/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32725 +/- ## ======================================= Coverage 81.78% 81.79% ======================================= Files 998 998 Lines 124292 124294 +2 ======================================= + Hits 101655 101669 +14 + Misses 18776 18759 -17 - Partials 3861 3866 +5 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32725?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/services.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32725?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fservices.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VydmljZXMuZ28=) | `90.57% <50.00%> (-0.74%)` | :arrow_down: | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32725/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
weiliu1031 commented 2 weeks ago

/lgtm