search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

fix: Fix cannot specify partition name in binlog import #32730

Closed bigsheeper closed 2 weeks ago

bigsheeper commented 3 weeks ago

issue: https://github.com/milvus-io/milvus/issues/32807

mergify[bot] commented 3 weeks ago

@bigsheeper Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] commented 3 weeks ago

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

czs007 commented 2 weeks ago

@bigsheeper rebase from master /approve

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.80%. Comparing base (83ce352) to head (697b3ba). Report is 18 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32730/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32730 +/- ## ========================================== + Coverage 81.77% 81.80% +0.02% ========================================== Files 1001 992 -9 Lines 125359 125645 +286 ========================================== + Hits 102517 102788 +271 - Misses 18956 18962 +6 - Partials 3886 3895 +9 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32730?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/proxy/impl.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32730?src=pr&el=tree&filepath=internal%2Fproxy%2Fimpl.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvaW1wbC5nbw==) | `86.37% <81.81%> (-0.11%)` | :arrow_down: | ... and [210 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32730/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
bigsheeper commented 2 weeks ago

issue: https://github.com/milvus-io/milvus/issues/32807

mergify[bot] commented 2 weeks ago

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

bigsheeper commented 2 weeks ago

/run-cpu-e2e

czs007 commented 2 weeks ago

/approve /lgtm

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/proxy/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/proxy/OWNERS)~~ [czs007] - ~~[tests/OWNERS](https://github.com/milvus-io/milvus/blob/master/tests/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment