milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

enhance: expose DescribeDatabase api in proxy #32732

Closed weiliu1031 closed 1 week ago

weiliu1031 commented 3 weeks ago

issue: #32707

mergify[bot] commented 3 weeks ago

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] commented 3 weeks ago

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:

    • feat: for introducing a new feature.
    • fix: for bug fixes.
    • enhance: for improvements to existing functionality.
    • test: for add tests to existing functionality.
    • doc: for modifying documentation.
    • auto: for the pull request from bot.
  2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 88.54962% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (17a79f4) to head (f0f8c69). Report is 13 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32732/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32732 +/- ## ======================================= Coverage 81.78% 81.79% ======================================= Files 1006 1006 Lines 126749 126845 +96 ======================================= + Hits 103664 103754 +90 + Misses 19147 19144 -3 - Partials 3938 3947 +9 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/distributed/proxy/service.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&filepath=internal%2Fdistributed%2Fproxy%2Fservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGlzdHJpYnV0ZWQvcHJveHkvc2VydmljZS5nbw==) | `84.06% <100.00%> (+0.04%)` | :arrow_up: | | [internal/proxy/task.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&filepath=internal%2Fproxy%2Ftask.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvdGFzay5nbw==) | `88.11% <ø> (-0.17%)` | :arrow_down: | | [internal/rootcoord/describe\_db\_task.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&filepath=internal%2Frootcoord%2Fdescribe_db_task.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcm9vdGNvb3JkL2Rlc2NyaWJlX2RiX3Rhc2suZ28=) | `86.66% <100.00%> (+0.95%)` | :arrow_up: | | [internal/proxy/impl.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&filepath=internal%2Fproxy%2Fimpl.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvaW1wbC5nbw==) | `86.43% <88.09%> (+0.01%)` | :arrow_up: | | [internal/proxy/task\_database.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32732?src=pr&el=tree&filepath=internal%2Fproxy%2Ftask_database.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvdGFza19kYXRhYmFzZS5nbw==) | `94.47% <88.37%> (-5.53%)` | :arrow_down: | ... and [25 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32732/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
mergify[bot] commented 2 weeks ago

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] commented 2 weeks ago

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

weiliu1031 commented 2 weeks ago

/run-cpu-e2e

congqixia commented 1 week ago

/cc @czs007

czs007 commented 1 week ago

/approve /lgtm

sre-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 1 week ago

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

weiliu1031 commented 1 week ago

/run-cpu-e2e

mergify[bot] commented 1 week ago

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

weiliu1031 commented 1 week ago

/run-cpu-e2e